Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:55448 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 77555 invoked from network); 15 Sep 2011 07:22:44 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Sep 2011 07:22:44 -0000 Authentication-Results: pb1.pair.com header.from=hannes.magnusson@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=hannes.magnusson@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.42 as permitted sender) X-PHP-List-Original-Sender: hannes.magnusson@gmail.com X-Host-Fingerprint: 209.85.213.42 mail-yw0-f42.google.com Received: from [209.85.213.42] ([209.85.213.42:49057] helo=mail-yw0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id BF/00-11511-CB7A17E4 for ; Thu, 15 Sep 2011 03:22:42 -0400 Received: by ywa8 with SMTP id 8so2227149ywa.29 for ; Thu, 15 Sep 2011 00:22:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=2JdJqYzgOlXUWRL9Q/cN93rykXmy0WcPZokCNcHNe2k=; b=lYSUDfk7ka1C2zw0urSbTYajFsjV7GWz1AY8RVDVs1m4w/bdK4q0B8b2G7g4PiGtsS XjTQBqB2ZeLiwWGvNsWJqE6wIIh7VwhRlQtvX55RS+iQPM/Ew7J4D4FHsI/fbFHN7gbR GAUQlDHu6Gxn98O7Q2PJzDakINuhit5eMSpdA= MIME-Version: 1.0 Received: by 10.236.78.200 with SMTP id g48mr4443027yhe.12.1316071339768; Thu, 15 Sep 2011 00:22:19 -0700 (PDT) Received: by 10.147.167.7 with HTTP; Thu, 15 Sep 2011 00:22:19 -0700 (PDT) In-Reply-To: References: <4E6FB55E.4060906@oracle.com> Date: Thu, 15 Sep 2011 09:22:19 +0200 Message-ID: To: Ferenc Kovacs Cc: Christopher Jones , internals@lists.php.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] Revert Tokenizer behavior for 5.4 From: hannes.magnusson@gmail.com (Hannes Magnusson) On Tue, Sep 13, 2011 at 22:08, Ferenc Kovacs wrote: > On Tue, Sep 13, 2011 at 9:56 PM, Christopher Jones > wrote: >> >> >> On 09/13/2011 12:25 PM, Nikita Popov wrote: >>> >>> I changed my previous patch to an SVN patch, so it is easier to apply >>> and added another patch (the one called "tokenizer_patch_full.txt"), >>> which additionally fetches the rest into a T_INLINE_HTML. (The "_full" >>> patch thus contains both changes. I didn't know how I could separate >>> them.) >> >> I haven't seen much "buy-in" about your email. =C2=A0You might want to w= ait >> until after Beta and revisit the topic later. =C2=A0If you add some conc= ise >> explanation it would be easier for people to weigh the pros and cons, >> see what breaks and what gets fixed etc. > > I agree that the lack of response is kind of disturbing: > no response in the bugreport, no response on the mailing list, almost > zero comment on irc. :/ > I can accept that if it won't make into 5.3, or even 5.4.0, but at > least it could be merged to trunk, if the patch is fine. > I think that Nicolas and Nikita did more than enough on their part, > could somebody please review the patch? the change to ext/tokenizer/tests/token_get_all_variation16.phpt seems really weird? And I'm unsure how this should actually work. A file containing: stuff Will return "stuff" after this patch.. that doesn't seem expected. -Hannes