Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:55445 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 6292 invoked from network); 14 Sep 2011 20:41:45 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 14 Sep 2011 20:41:45 -0000 Authentication-Results: pb1.pair.com smtp.mail=scott@macvicar.net; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=scott@macvicar.net; sender-id=unknown Received-SPF: error (pb1.pair.com: domain macvicar.net from 209.85.210.170 cause and error) X-PHP-List-Original-Sender: scott@macvicar.net X-Host-Fingerprint: 209.85.210.170 mail-iy0-f170.google.com Received: from [209.85.210.170] ([209.85.210.170:45048] helo=mail-iy0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 2A/20-05109-881117E4 for ; Wed, 14 Sep 2011 16:41:45 -0400 Received: by iadj38 with SMTP id j38so520603iad.29 for ; Wed, 14 Sep 2011 13:41:42 -0700 (PDT) Received: by 10.42.147.2 with SMTP id l2mr183759icv.378.1316032902000; Wed, 14 Sep 2011 13:41:42 -0700 (PDT) Received: from asabalambp13.thefacebook.com ([66.220.144.73]) by mx.google.com with ESMTPS id df21sm1520406ibb.9.2011.09.14.13.41.40 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 14 Sep 2011 13:41:40 -0700 (PDT) Mime-Version: 1.0 (Apple Message framework v1244.3) Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: Date: Wed, 14 Sep 2011 13:41:42 -0700 Cc: Alexey Shein , PHP Internals Content-Transfer-Encoding: quoted-printable Message-ID: <31E67531-0C43-4131-8C9B-405E7C954695@macvicar.net> References: To: Pierre Joye X-Mailer: Apple Mail (2.1244.3) Subject: Re: [PHP-DEV] Running mhash tests From: scott@macvicar.net (Scott MacVicar) On 14 Sep 2011, at 13:26, Pierre Joye wrote: > hi, >=20 > On Wed, Sep 14, 2011 at 9:58 PM, Alexey Shein = wrote: >=20 >> Should we delete these tests (and, maybe deprecate/move to pecl the >> extension itself)? >=20 > I don't think we should, they are here to make sure that the emulation > layer works fine. >=20 >> If not, I'd like to know how to run these tests. >=20 > Maybe the skipif is wrong, as far as I remember there was an issue > with seeing the "mhash" layer as being the mhash extension. Maybe we > should change the skipif and uses function_exists instead? Have you > tried it? It definitely should have a 'mhash' entry, it creates a = mhash_module_entry and registers that. If you enable mash only, it silently enables hash. - Scott=