Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:55416 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 54928 invoked from network); 13 Sep 2011 20:08:16 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 Sep 2011 20:08:16 -0000 Authentication-Results: pb1.pair.com header.from=tyra3l@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=tyra3l@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.170 as permitted sender) X-PHP-List-Original-Sender: tyra3l@gmail.com X-Host-Fingerprint: 209.85.213.170 mail-yx0-f170.google.com Received: from [209.85.213.170] ([209.85.213.170:53152] helo=mail-yx0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F9/DF-09632-F28BF6E4 for ; Tue, 13 Sep 2011 16:08:15 -0400 Received: by yxi13 with SMTP id 13so870156yxi.29 for ; Tue, 13 Sep 2011 13:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=xu+ezW4NgWlvD3lmRJuhdnL5GXZ0EAeRZFj56XpbwZ8=; b=pTRiO7P+MEgSgoxW+U+i37r0eHQKK/bm9P39RFEe/Kjpv3/jS6IwLlTGqpL6Jn1yjY V61gfl7lS4eItMaSHplYSgJzM1/YxdHzu5YUgFaxaKt00nFURs/cd9ZWOmhcSPoF2tEA mkyRiYpxA2iZIR9RCxhYve4M1PAe6m6BevP28= MIME-Version: 1.0 Received: by 10.236.37.134 with SMTP id y6mr25976474yha.113.1315944493201; Tue, 13 Sep 2011 13:08:13 -0700 (PDT) Received: by 10.147.125.13 with HTTP; Tue, 13 Sep 2011 13:08:13 -0700 (PDT) In-Reply-To: <4E6FB55E.4060906@oracle.com> References: <4E6FB55E.4060906@oracle.com> Date: Tue, 13 Sep 2011 22:08:13 +0200 Message-ID: To: Christopher Jones Cc: internals@lists.php.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] Revert Tokenizer behavior for 5.4 From: tyra3l@gmail.com (Ferenc Kovacs) On Tue, Sep 13, 2011 at 9:56 PM, Christopher Jones wrote: > > > On 09/13/2011 12:25 PM, Nikita Popov wrote: >> >> I changed my previous patch to an SVN patch, so it is easier to apply >> and added another patch (the one called "tokenizer_patch_full.txt"), >> which additionally fetches the rest into a T_INLINE_HTML. (The "_full" >> patch thus contains both changes. I didn't know how I could separate >> them.) > > I haven't seen much "buy-in" about your email. =C2=A0You might want to wa= it > until after Beta and revisit the topic later. =C2=A0If you add some conci= se > explanation it would be easier for people to weigh the pros and cons, > see what breaks and what gets fixed etc. I agree that the lack of response is kind of disturbing: no response in the bugreport, no response on the mailing list, almost zero comment on irc. :/ I can accept that if it won't make into 5.3, or even 5.4.0, but at least it could be merged to trunk, if the patch is fine. I think that Nicolas and Nikita did more than enough on their part, could somebody please review the patch? --=20 Ferenc Kov=C3=A1cs @Tyr43l - http://tyrael.hu