Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:55415 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 50235 invoked from network); 13 Sep 2011 19:56:28 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 Sep 2011 19:56:28 -0000 Authentication-Results: pb1.pair.com header.from=christopher.jones@oracle.com; sender-id=unknown Authentication-Results: pb1.pair.com smtp.mail=christopher.jones@oracle.com; spf=permerror; sender-id=unknown Received-SPF: error (pb1.pair.com: domain oracle.com from 141.146.126.227 cause and error) X-PHP-List-Original-Sender: christopher.jones@oracle.com X-Host-Fingerprint: 141.146.126.227 acsinet15.oracle.com Received: from [141.146.126.227] ([141.146.126.227:52705] helo=acsinet15.oracle.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 0A/EE-09632-A65BF6E4 for ; Tue, 13 Sep 2011 15:56:27 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by acsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p8DJuMRr008899 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 13 Sep 2011 19:56:24 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p8DJuLct019290 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 13 Sep 2011 19:56:22 GMT Received: from abhmt115.oracle.com (abhmt115.oracle.com [141.146.116.67]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p8DJuGiw029811 for ; Tue, 13 Sep 2011 14:56:16 -0500 Received: from [130.35.70.206] (/130.35.70.206) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 13 Sep 2011 12:56:16 -0700 Message-ID: <4E6FB55E.4060906@oracle.com> Date: Tue, 13 Sep 2011 12:56:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:6.0) Gecko/20110812 Thunderbird/6.0 MIME-Version: 1.0 To: internals@lists.php.net References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A090205.4E6FB568.0047:SCFMA922111,ss=1,re=-4.000,fgs=0 Subject: Re: [PHP-DEV] Revert Tokenizer behavior for 5.4 From: christopher.jones@oracle.com (Christopher Jones) On 09/13/2011 12:25 PM, Nikita Popov wrote: > I changed my previous patch to an SVN patch, so it is easier to apply > and added another patch (the one called "tokenizer_patch_full.txt"), > which additionally fetches the rest into a T_INLINE_HTML. (The "_full" > patch thus contains both changes. I didn't know how I could separate > them.) I haven't seen much "buy-in" about your email. You might want to wait until after Beta and revisit the topic later. If you add some concise explanation it would be easier for people to weigh the pros and cons, see what breaks and what gets fixed etc. Chris > > Could somebody apply the patch or give me advice how to improve it, so > it can be applied? > Thanks. > > On Tue, Sep 13, 2011 at 9:57 AM, Nicolas Grekas > wrote: >> >>> I just set up an PHP environment and wrote a proper patch (including test >>> changes) to make it collect the next three tokens. It's a git patch and I'm >>> not sure whether it's compatible with SVN patches. I would love it if this >>> would go into 5.4 before beta. I didn't know how one could fetch the rest >>> into T_INLINE_HTML, so I'm hoping on help here from someone who actually >>> knowns C there :) >> >> I just reopened the bug and posted an excerpt of this discussion with your >> patch : >> >> https://bugs.php.net/bug.php?id=54089 >> >> Nicolas >> > -- Email: christopher.jones@oracle.com Tel: +1 650 506 8630 Blog: http://blogs.oracle.com/opal/