Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:55414 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 32791 invoked from network); 13 Sep 2011 19:25:53 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 Sep 2011 19:25:53 -0000 Authentication-Results: pb1.pair.com smtp.mail=nikita.ppv@googlemail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=nikita.ppv@googlemail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain googlemail.com designates 209.85.215.170 as permitted sender) X-PHP-List-Original-Sender: nikita.ppv@googlemail.com X-Host-Fingerprint: 209.85.215.170 mail-ey0-f170.google.com Received: from [209.85.215.170] ([209.85.215.170:48917] helo=mail-ey0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 23/1B-09632-04EAF6E4 for ; Tue, 13 Sep 2011 15:25:53 -0400 Received: by eyd10 with SMTP id 10so632885eyd.29 for ; Tue, 13 Sep 2011 12:25:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=GeqQqBraNCIRKXs9dZ94TV2AwoI/9/p/Z4NKnGX/m1k=; b=Ve/Jc3dyoGnu8fVjxxNYBSvHJwkkIjmEuJq768YGF7yrnw46UIP3hcTJdKZzM4jV2W Zovrdpy99HsXYuAWvIjF2vPfBTLa+Tol5IDQkHueaEQzqnKqxlAgkzSXkodcvG/0WwNo wPikWRGlz1Pmmys0ZBkF+uaGz9GuUYhS+L7eA= MIME-Version: 1.0 Received: by 10.14.31.228 with SMTP id m76mr815476eea.142.1315941949297; Tue, 13 Sep 2011 12:25:49 -0700 (PDT) Received: by 10.14.99.205 with HTTP; Tue, 13 Sep 2011 12:25:49 -0700 (PDT) In-Reply-To: References: Date: Tue, 13 Sep 2011 21:25:49 +0200 Message-ID: To: Nicolas Grekas Cc: Ferenc Kovacs , PHP internals Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [PHP-DEV] Revert Tokenizer behavior for 5.4 From: nikita.ppv@googlemail.com (Nikita Popov) I changed my previous patch to an SVN patch, so it is easier to apply and added another patch (the one called "tokenizer_patch_full.txt"), which additionally fetches the rest into a T_INLINE_HTML. (The "_full" patch thus contains both changes. I didn't know how I could separate them.) Could somebody apply the patch or give me advice how to improve it, so it can be applied? Thanks. On Tue, Sep 13, 2011 at 9:57 AM, Nicolas Grekas wrote: > >> I just set up an PHP environment and wrote a proper patch (including test >> changes) to make it collect the next three tokens. It's a git patch and I'm >> not sure whether it's compatible with SVN patches. I would love it if this >> would go into 5.4 before beta. I didn't know how one could fetch the rest >> into T_INLINE_HTML, so I'm hoping on help here from someone who actually >> knowns C there :) > > I just reopened the bug and posted an excerpt of this discussion with your > patch : > > https://bugs.php.net/bug.php?id=54089 > > Nicolas >