Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:5540
Return-Path: <pollita@php.net>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 83046 invoked by uid 1010); 19 Nov 2003 05:20:13 -0000
Delivered-To: ezmlm-scan-internals@lists.php.net
Delivered-To: ezmlm-internals@lists.php.net
Received: (qmail 82990 invoked by uid 1007); 19 Nov 2003 05:20:13 -0000
Message-ID: <20031119052013.82989.qmail@pb1.pair.com>
To: internals@lists.php.net
References: <5.1.0.14.2.20031118235848.0347c9f0@127.0.0.1>
Date: Tue, 18 Nov 2003 21:20:06 -0800
Lines: 29
X-Priority: 3
X-MSMail-Priority: Normal
X-Newsreader: Microsoft Outlook Express 6.00.2800.1158
X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165
X-Posted-By: 64.142.6.231
Subject: Re: E_STRICT
From: pollita@php.net ("Sara Golemon")

> I added an E_STRICT error level today which purists can use to make sure
> that there scripts are using the latest and greatest suggested method of
> coding (according to what we decide).
>
Should E_STRICT halt execution (as with E_ERROR) or simply state a warning
(as with E_NOTICE / E_WARNING)?

Either way main/main.c : php_error_cb() needs something like the following
(Looking for thoughts on exact verbage)

Index: main/main.c
===================================================================
RCS file: /repository/php-src/main/main.c,v
retrieving revision 1.579
diff -u -r1.579 main.c
--- main/main.c 9 Oct 2003 02:58:34 -0000       1.579
+++ main/main.c 19 Nov 2003 05:18:15 -0000
@@ -723,6 +723,9 @@
                        case E_USER_NOTICE:
                                error_type_str = "Notice";
                                break;
+                       case E_STRICT:
+                               error_type_str = "Strict Standards";
+                               break;
                        default:
                                error_type_str = "Unknown error";
                                break;