Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55367
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.83.53 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4E6D1340.6010408@elitehosts.com>
References: <4E6B9466.6060608@elitehosts.com>
	<CABBJUpcPqMtjhjBiaDU=TaOOqCM6o0sdjDgjkJ0BDi_dmnP5jQ@mail.gmail.com>
	<CAEZPtU4_KBWd=82-svSeNH+-U=xGiLLhXTc52HT9=Sy2dunnYA@mail.gmail.com>
	<4E6D1340.6010408@elitehosts.com>
Date: Sun, 11 Sep 2011 22:24:04 +0200
Message-ID: <CAEZPtU6k_-9cEeGvnDzVcBP0xZ68aptUMhEqfc=CPJqsxt8p8Q@mail.gmail.com>
To: Avi Brender <abrender@elitehosts.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [PATCH]#55651
From: pierre.php@gmail.com (Pierre Joye)

hi!

Please upload the patch in the bug tracker as well.

It would be also better to use a more verbose name.
FTP_OPT_USEPASVADDRESS is somehow cryptic.

Laruence's comment is still valid, the zval should be converted if it
is not int or bool.

Btw, could you test cases as well please?

Cheers,

On Sun, Sep 11, 2011 at 10:00 PM, Avi Brender <abrender@elitehosts.com> wro=
te:
> Hi,
>
> I've updated the patch - please see attached.
>
> Avi Brender
> Elite Hosts, Inc
> www.elitehosts.com
> ------------------------------------------------
> WARNING !!! This email message is for the sole use of the intended
> recipient(s) and may contain confidential and privileged information. Any
> unauthorized review; use, disclosure or distribution is prohibited, and
> could result in criminal prosecution. If you are not the intended recipie=
nt,
> please contact the sender by reply email and destroy all copies of the
> original message. This message is private and is considered a confidentia=
l
> exchange - public disclosure of this electronic message or its contents a=
re
> prohibited.
>
> On 09/11/2011 10:53 AM, Pierre Joye wrote:
>> hi,
>>
>> A simple test if it is IS_BOOL or IS_LONG should be enough, both types
>> use the the long value (convert_to_boolean_ex is slow and duplicate
>> the zval while it is not necessary). Then test > 0 instead of simply
>> assigning the value.
>>
>> On Sun, Sep 11, 2011 at 5:59 AM, Laruence <laruence@php.net> wrote:
>>> Hi:
>>> =A0 =A0after a quick look, =A0I have one suggestion,
>>> =A0 =A0if the (Z_TYPE_P(z_value) !=3D IS_BOOL), you should call
>>> convert_to_boolean_ex to convert it to a boolean
>>> =A0 =A0otherwise, people can not use a interge 1 as a true flag.
>>>
>>> =A0 =A0thanks
>>>
>>> 2011/9/11 Avi Brender <abrender@elitehosts.com>:
>>>> Hi,
>>>>
>>>> I've submitted bug #55651 along with a patch to implement a fix (also
>>>> attached) for the passive FTP mode issue. I was hoping that someone
>>>> could
>>>> review the bug report and consider the patch for inclusion in future P=
HP
>>>> releases.
>>>>
>>>> Thanks so much!
>>>>
>>>> Avi Brender
>>>> Elite Hosts, Inc
>>>> www.elitehosts.com
>>>>
>>>> --
>>>> PHP Internals - PHP Runtime Development Mailing List
>>>> To unsubscribe, visit: http://www.php.net/unsub.php
>>>>
>>>
>>>
>>>
>>> --
>>> Laruence =A0Xinchen Hui
>>> http://www.laruence.com/
>>>
>>> --
>>> PHP Internals - PHP Runtime Development Mailing List
>>> To unsubscribe, visit: http://www.php.net/unsub.php
>>>
>>>
>>
>>
>>
>
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>



--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org