Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:55363 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 19441 invoked from network); 11 Sep 2011 14:53:52 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 11 Sep 2011 14:53:52 -0000 Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.170 as permitted sender) X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.160.170 mail-gy0-f170.google.com Received: from [209.85.160.170] ([209.85.160.170:62653] helo=mail-gy0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E1/A6-45650-D7BCC6E4 for ; Sun, 11 Sep 2011 10:53:50 -0400 Received: by gyb11 with SMTP id 11so1405177gyb.29 for ; Sun, 11 Sep 2011 07:53:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=nVj9Ko7Whh8Oqu5QskL9jwGFXFYDL79hEgIbbjD1Amc=; b=brAcZQBTlpi21iGMiR/LqcEIRYAiHbNxngZ2jphK191yUpSZ+ILUM3plFqGIcr0o22 nn2PTCID7V9ltrlP9gv4PvDoktUh0O/w/N8eLWmgE8RNSFq3IQAbsvotiiQH+JFYTm22 n2WXBTq9XOa4lcU/LQLKliulC+sthmDPZWzIk= MIME-Version: 1.0 Received: by 10.236.79.197 with SMTP id i45mr21239000yhe.28.1315752826584; Sun, 11 Sep 2011 07:53:46 -0700 (PDT) Received: by 10.147.99.13 with HTTP; Sun, 11 Sep 2011 07:53:46 -0700 (PDT) In-Reply-To: References: <4E6B9466.6060608@elitehosts.com> Date: Sun, 11 Sep 2011 16:53:46 +0200 Message-ID: To: Laruence Cc: Avi Brender , internals@lists.php.net Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] [PATCH]#55651 From: pierre.php@gmail.com (Pierre Joye) hi, A simple test if it is IS_BOOL or IS_LONG should be enough, both types use the the long value (convert_to_boolean_ex is slow and duplicate the zval while it is not necessary). Then test > 0 instead of simply assigning the value. On Sun, Sep 11, 2011 at 5:59 AM, Laruence wrote: > Hi: > =A0 =A0after a quick look, =A0I have one suggestion, > =A0 =A0if the (Z_TYPE_P(z_value) !=3D IS_BOOL), you should call > convert_to_boolean_ex to convert it to a boolean > =A0 =A0otherwise, people can not use a interge 1 as a true flag. > > =A0 =A0thanks > > 2011/9/11 Avi Brender : >> Hi, >> >> I've submitted bug #55651 along with a patch to implement a fix (also >> attached) for the passive FTP mode issue. I was hoping that someone coul= d >> review the bug report and consider the patch for inclusion in future PHP >> releases. >> >> Thanks so much! >> >> Avi Brender >> Elite Hosts, Inc >> www.elitehosts.com >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> > > > > -- > Laruence =A0Xinchen Hui > http://www.laruence.com/ > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > --=20 Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org