Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55356
Return-Path: <laruence@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 67258 invoked from network); 11 Sep 2011 03:59:46 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 11 Sep 2011 03:59:46 -0000
Authentication-Results: pb1.pair.com smtp.mail=laruence@gmail.com; spf=pass; sender-id=pass
Authentication-Results: pb1.pair.com header.from=laruence@gmail.com; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.54 as permitted sender)
X-PHP-List-Original-Sender: laruence@gmail.com
X-Host-Fingerprint: 209.85.212.54 mail-vw0-f54.google.com  
Received: from [209.85.212.54] ([209.85.212.54:62920] helo=mail-vw0-f54.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 4B/12-45650-0323C6E4 for <internals@lists.php.net>; Sat, 10 Sep 2011 23:59:45 -0400
Received: by vws18 with SMTP id 18so2978248vws.13
        for <internals@lists.php.net>; Sat, 10 Sep 2011 20:59:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:from:date
         :x-google-sender-auth:message-id:subject:to:cc:content-type
         :content-transfer-encoding;
        bh=YdrZyxjCEdv6DZjYrDYgHRB/bQOtuqSiSOxk0UCPdFU=;
        b=LQ29GUQm135kRkeMOTG5qskschKHku1HjiDNVNt9lNB20jm+E9hQjI/rcl9/lQ0U4/
         leqg8whZhut1bFrYoXUv56IkQD1CwEQuYheCB8f9AMYEJbeyMWfMrcOHw9Qs+b0+0R+F
         bb5muMOPHZuazGPjt6XUtTNTWPrql9dh3GKuE=
Received: by 10.220.181.13 with SMTP id bw13mr958249vcb.187.1315713581071;
 Sat, 10 Sep 2011 20:59:41 -0700 (PDT)
MIME-Version: 1.0
Sender: laruence@gmail.com
Received: by 10.220.94.142 with HTTP; Sat, 10 Sep 2011 20:59:21 -0700 (PDT)
In-Reply-To: <4E6B9466.6060608@elitehosts.com>
References: <4E6B9466.6060608@elitehosts.com>
Date: Sun, 11 Sep 2011 11:59:21 +0800
X-Google-Sender-Auth: f16DdypxnTaYjgXwtCArN5FvLDQ
Message-ID: <CABBJUpcPqMtjhjBiaDU=TaOOqCM6o0sdjDgjkJ0BDi_dmnP5jQ@mail.gmail.com>
To: Avi Brender <abrender@elitehosts.com>
Cc: internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [PATCH]#55651
From: laruence@php.net (Laruence)

Hi:
    after a quick look,  I have one suggestion,
    if the (Z_TYPE_P(z_value) !=3D IS_BOOL), you should call
convert_to_boolean_ex to convert it to a boolean
    otherwise, people can not use a interge 1 as a true flag.

    thanks

2011/9/11 Avi Brender <abrender@elitehosts.com>:
> Hi,
>
> I've submitted bug #55651 along with a patch to implement a fix (also
> attached) for the passive FTP mode issue. I was hoping that someone could
> review the bug report and consider the patch for inclusion in future PHP
> releases.
>
> Thanks so much!
>
> Avi Brender
> Elite Hosts, Inc
> www.elitehosts.com
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>



--=20
Laruence =C2=A0Xinchen Hui
http://www.laruence.com/