Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55306
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.174 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAAAa2siG4c8rbDR1VBaJZBc2bGpccaY3qHKagAuVkA5-gMkX3A@mail.gmail.com>
References: <CAAAa2siG4c8rbDR1VBaJZBc2bGpccaY3qHKagAuVkA5-gMkX3A@mail.gmail.com>
Date: Thu, 8 Sep 2011 15:00:12 +0200
Message-ID: <CAH-PCH7wT3LY+XxmXwkAJ2gfoYH1+KBjP8qvVt2S5Twr_a5JOg@mail.gmail.com>
To: Alexey Shein <confik@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [PATCH] Autoguessing TEST_PHP_EXECUTABLE if none is
 provided in run-tests.php
From: tyra3l@gmail.com (Ferenc Kovacs)

On Thu, Sep 8, 2011 at 2:07 PM, Alexey Shein <confik@gmail.com> wrote:
> Hello!
> I've made some improvements to run-tests.php:
> 1) Autoguessing TEST_PHP_EXECUTABLE and TEST_PHP_CGI_EXECUTABLE if
> they're not provided, i.e. assume they have value 'auto'. You can
> still pass your own value as usual.
> 2) Added option -n (use no php.ini) to the shebang line
> (#!/usr/bin/php -n) so it would run more reliably on some hosts. My
> Ubuntu setup did not have E letter in variables_order (i.e.
> variables_order=3DGPCS) so $_ENV array was empty and some tests were
> skipped when they could be run.
> 3) Some better error handling of wrong paths
>
> So now you can run run-tests.php with just
> $ ./run-tests.php ext
> instead of
> $ TEST_PHP_EXECUTABLE=3Dauto php -n run-tests.php ext
>
> You can also run run-tests.php from sub-dir, it will correctly guess
> 'auto' as well:
> $ cd ext/
> $ ../run-tests.php zlib
>
> Please, review this patch and, if there's no objections, I will
> prepare 5.4 and 5.3 versions too.

for the record, the "Don't ever guess at the PHP executable location."
comments was made back in 2002
http://svn.php.net/viewvc?view=3Drevision&revision=3D82472 and at time the
part of the code which guessed the php binary was pretty messy, so I
think that now we would be safe to use the "auto" for default.

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu