Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55248
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4E6630F7.2060906@oracle.com>
References: <4E6630F7.2060906@oracle.com>
Date: Tue, 6 Sep 2011 18:19:49 +0200
Message-ID: <CAEZPtU4r6XOeSm-49rvvSj9SKGCVO0Hp7_OW-a_z9VUdVcv27g@mail.gmail.com>
To: Ulf Wendel <ulf.wendel@oracle.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Borked SKIPIFs (PHP_5_4)
From: pierre.php@gmail.com (Pierre Joye)

hi Ulf,

I fixed two. Feel free to fix the other as well if you have time.

On Tue, Sep 6, 2011 at 4:40 PM, Ulf Wendel <ulf.wendel@oracle.com> wrote:
> Hi,
>
> annoyed by run-tests.php ignoring borked SKIPIF sections, I hacked it to
> bail out at me if something seemed suspicious. Maintainers may want to ha=
ve
> a look at:
>
> Fatal/Parse error @ SKIPIF =3D SKIPIF non functional
>
> =A0BORK 883/9126 [Zend/tests/bug31683.phpt]
> =A0BORK 4037/9248 [ext/phar/tests/fopen_edgecases2.phpt
> =A0BORK 8443/9248 [ext/standard/tests/strings/md5_file.phpt]
> =A0BORK 8514/9248 [ext/standard/tests/strings/sha1_file.phpt]
>
> Warnings/Notices @ SKIPIF =3D SKIPIF should work fine
>
> =A0BORK 4451/9248 [ext/posix/tests/posix_getpgid_error.phpt]
> =A0BORK 4452/9248 [ext/posix/test/posix_getpgid_variation.phpt]
> =A0BORK 4865/9248 [ext/session/test/rfc1867_invalid_settings.phpt]
> =A0BORK 7328/9248 [ext/standard/tests/file/php_fd_wrapper_04.phpt]
>
> My PHP was built with pretty much nothing but MySQL stuff enabled. A fair
> number of tests has probably been skipped.
>
> The run-tests.php hack I used is not worth sharing. All I did was check i=
f
> SKIPIF returns any output after removal of "-d display_errors=3D0". In ot=
her
> words I made the assumption that SKIPIF sections must not output anything
> but "skip <message>" or the like, which causes false positives.
>
> Ulf
>
>
>
>
>
> Details:
>
>
> BORK 883/9126 [Zend/tests/bug31683.phpt]
>
> Warning: require_once(skipif.inc): failed to open stream: No such file or
> directory in
> /home/nixnutz/php/php-src/branches/PHP_5_4/Zend/tests/bug31683.skip.php o=
n
> line 1
> Fatal error: require_once(): Failed opening required 'skipif.inc'
> (include_path=3D'.:/usr/local/lib/php') in
> /home/nixnutz/php/php-src/branches/PHP_5_4/Zend/tests/bug31683.skip.php o=
n
> line 1
>
>
> BORK 4037/9248 [ext/phar/tests/fopen_edgecases2.phpt
>
> Fatal error: Call to undefined function php_version() in
> /home/nixnutz/php/php-src/branches/PHP_5_4/ext/phar/tests/fopen_edgecases=
2.skip.php
> on line 2
>
>
> BORK 4451/9248 [ext/posix/tests/posix_getpgid_error.phpt]
>
> Notice: Use of undefined constant posix_getpgid - assumed 'posix_getpgid'=
 in
> /home/nixnutz/php/php-src/branches/PHP_5_4/ext/posix/tests/posix_getpgid_=
error.skip.php
> on line 2
> =A0[] ext/posix/tests/posix_getpgid_error.phpt
>
>
> BORK 4452/9248 [ext/posix/test/posix_getpgid_variation.phpt]
>
> Notice: Use of undefined constant posix_getpgid - assumed 'posix_getpgid'=
 in
> /home/nixnutz/php/php-src/branches/PHP_5_4/ext/posix/tests/posix_getpgid_=
variation.skip.php
> on line 2
>
>
> BORK 4865/9248 [ext/session/test/rfc1867_invalid_settings.phpt]
>
> Warning: PHP Startup: session.upload_progress.freq must be greater than o=
r
> equal to zero in Unknown on line 0
>
>
> BORK 4866/9248 [ext/session/tests/rfc1867_invalid_settings_2.phpt]
>
> Warning: PHP Startup: session.upload_progress.freq cannot be over 100% in
> Unknown on line 0
>
>
> BORK 7328/9248 [ext/standard/tests/file/php_fd_wrapper_04.phpt]
>
> Warning: include(skipif.inc): failed to open stream: No such file or
> directory in
> /home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/file/php_fd=
_wrapper_04.skip.php
> on line 1
>
>
> Warning: include(): Failed opening 'skipif.inc' for inclusion
> (include_path=3D'.:/usr/local/lib/php') in
> /home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/file/php_fd=
_wrapper_04.skip.php
> in line 1
>
>
> BORK 8443/9248 [ext/standard/tests/strings/md5_file.phpt]
>
> Parse error: syntax error, unexpected '!', expecting '(' in
> /home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/strings/md5=
_file.skip.php
> on line 6
>
>
> BORK 8514/9248 [ext/standard/tests/strings/sha1_file.phpt]
>
> Parse error: syntax error, unexpected '!', expecting '(' in
> /home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/strings/sha=
1_file.skip.php
> on line 6
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>



--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org