Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55246
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain oracle.com from 141.146.126.227 cause and error)
Message-ID: <4E6630F7.2060906@oracle.com>
Date: Tue, 06 Sep 2011 16:40:55 +0200
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:6.0.1) Gecko/20110830 Thunderbird/6.0.1
MIME-Version: 1.0
To: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Borked SKIPIFs (PHP_5_4)
From: ulf.wendel@oracle.com (Ulf Wendel)

Hi,

annoyed by run-tests.php ignoring borked SKIPIF sections, I hacked it to 
bail out at me if something seemed suspicious. Maintainers may want to 
have a look at:

Fatal/Parse error @ SKIPIF = SKIPIF non functional

   BORK 883/9126 [Zend/tests/bug31683.phpt]
   BORK 4037/9248 [ext/phar/tests/fopen_edgecases2.phpt
   BORK 8443/9248 [ext/standard/tests/strings/md5_file.phpt]
   BORK 8514/9248 [ext/standard/tests/strings/sha1_file.phpt]

Warnings/Notices @ SKIPIF = SKIPIF should work fine

   BORK 4451/9248 [ext/posix/tests/posix_getpgid_error.phpt]
   BORK 4452/9248 [ext/posix/test/posix_getpgid_variation.phpt]
   BORK 4865/9248 [ext/session/test/rfc1867_invalid_settings.phpt]
   BORK 7328/9248 [ext/standard/tests/file/php_fd_wrapper_04.phpt]

My PHP was built with pretty much nothing but MySQL stuff enabled. A 
fair number of tests has probably been skipped.

The run-tests.php hack I used is not worth sharing. All I did was check 
if SKIPIF returns any output after removal of "-d display_errors=0". In 
other words I made the assumption that SKIPIF sections must not output 
anything but "skip <message>" or the like, which causes false positives.

Ulf





Details:


BORK 883/9126 [Zend/tests/bug31683.phpt]

Warning: require_once(skipif.inc): failed to open stream: No such file 
or directory in 
/home/nixnutz/php/php-src/branches/PHP_5_4/Zend/tests/bug31683.skip.php 
on line 1
Fatal error: require_once(): Failed opening required 'skipif.inc' 
(include_path='.:/usr/local/lib/php') in 
/home/nixnutz/php/php-src/branches/PHP_5_4/Zend/tests/bug31683.skip.php 
on line 1


BORK 4037/9248 [ext/phar/tests/fopen_edgecases2.phpt

Fatal error: Call to undefined function php_version() in 
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/phar/tests/fopen_edgecases2.skip.php 
on line 2


BORK 4451/9248 [ext/posix/tests/posix_getpgid_error.phpt]

Notice: Use of undefined constant posix_getpgid - assumed 
'posix_getpgid' in 
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/posix/tests/posix_getpgid_error.skip.php 
on line 2
  [] ext/posix/tests/posix_getpgid_error.phpt


BORK 4452/9248 [ext/posix/test/posix_getpgid_variation.phpt]

Notice: Use of undefined constant posix_getpgid - assumed 
'posix_getpgid' in 
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/posix/tests/posix_getpgid_variation.skip.php 
on line 2


BORK 4865/9248 [ext/session/test/rfc1867_invalid_settings.phpt]

Warning: PHP Startup: session.upload_progress.freq must be greater than 
or equal to zero in Unknown on line 0


BORK 4866/9248 [ext/session/tests/rfc1867_invalid_settings_2.phpt]

Warning: PHP Startup: session.upload_progress.freq cannot be over 100% 
in Unknown on line 0


BORK 7328/9248 [ext/standard/tests/file/php_fd_wrapper_04.phpt]

Warning: include(skipif.inc): failed to open stream: No such file or 
directory in 
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/file/php_fd_wrapper_04.skip.php 
on line 1 
 


Warning: include(): Failed opening 'skipif.inc' for inclusion 
(include_path='.:/usr/local/lib/php') in 
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/file/php_fd_wrapper_04.skip.php 
in line 1


BORK 8443/9248 [ext/standard/tests/strings/md5_file.phpt]

Parse error: syntax error, unexpected '!', expecting '(' in 
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/strings/md5_file.skip.php 
on line 6


BORK 8514/9248 [ext/standard/tests/strings/sha1_file.phpt]

Parse error: syntax error, unexpected '!', expecting '(' in 
/home/nixnutz/php/php-src/branches/PHP_5_4/ext/standard/tests/strings/sha1_file.skip.php 
on line 6