Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55234
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4E652597.7070600@sugarcrm.com>
References: <CAEZPtU4+cWrcKqqAEwGiyYkYoThPc3o7rgAfWBSwDSdRw3r6mQ@mail.gmail.com>
	<4E652597.7070600@sugarcrm.com>
Date: Mon, 5 Sep 2011 21:49:09 +0200
Message-ID: <CAEZPtU6FxMbshR5TBaYS+ZEXf5ZqcbQOidM5d=hCnUpxbiiszA@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] drop TZ environment variable support in 5.4+?
From: pierre.php@gmail.com (Pierre Joye)

On Mon, Sep 5, 2011 at 9:40 PM, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> Hi!
>
> On 9/5/11 6:57 AM, Pierre Joye wrote:
>>
>> The main problem is that putenv and getenv are not thread safe and
>> many tests will fail either when using TS SAPIs or on Windows. This
>
> I'm not sure I understand how putenv() being non-thread-safe leads to tests
> failing - tests aren't threaded and AFAIK TS API doesn't do anything special
> there. Can you explain?

getenv and putenv are per se not threadsafe.

>> method is already deprecated and it is recommended to rely on the
>> other methods.
>
> Unfortunately, some functions - like strftime - still are TZ-dependant on
> some systems (like Darwin), so ignoring TZ altogether is not achievable. And
> once we have people use TZ, why not have it work for all?

It is not about ignoring the timezone, it is about dropping something
that we already have deprecated and that should have been removed
since long already. Also the date extension documents and say that the
right way to do it is to use either the ini settings or the tz setter
function.

strftime is a system function, not something we can do about it (and
noone should use it tbh, really not, there are better date/time
formatting function now). And users still relying on it can still set
the process TZ using putenv as they used to do, and get all the issues
 while being at it, they know them as they already live with them. The
only difference is that the date codes won't be affected.

Cheers,
--
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org