Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:55223 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 97780 invoked from network); 5 Sep 2011 13:34:56 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 5 Sep 2011 13:34:56 -0000 Authentication-Results: pb1.pair.com smtp.mail=ulf.wendel@oracle.com; spf=permerror; sender-id=unknown Authentication-Results: pb1.pair.com header.from=ulf.wendel@oracle.com; sender-id=unknown Received-SPF: error (pb1.pair.com: domain oracle.com from 148.87.113.117 cause and error) X-PHP-List-Original-Sender: ulf.wendel@oracle.com X-Host-Fingerprint: 148.87.113.117 rcsinet15.oracle.com Received: from [148.87.113.117] ([148.87.113.117:65376] helo=rcsinet15.oracle.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 09/75-64330-FFFC46E4 for ; Mon, 05 Sep 2011 09:34:56 -0400 Received: from rtcsinet21.oracle.com (rtcsinet21.oracle.com [66.248.204.29]) by rcsinet15.oracle.com (Switch-3.4.4/Switch-3.4.4) with ESMTP id p85DYiQ3010671 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 5 Sep 2011 13:34:46 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by rtcsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id p85DYgr0003895 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 5 Sep 2011 13:34:43 GMT Received: from abhmt106.oracle.com (abhmt106.oracle.com [141.146.116.58]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id p85DYbpP007972; Mon, 5 Sep 2011 08:34:37 -0500 Received: from [192.168.2.116] (/91.58.121.228) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 05 Sep 2011 06:34:36 -0700 Message-ID: <4E64CFEF.3050901@oracle.com> Date: Mon, 05 Sep 2011 15:34:39 +0200 User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:6.0.1) Gecko/20110830 Thunderbird/6.0.1 MIME-Version: 1.0 To: Andrey Hristov CC: internals@lists.php.net, Stas Malyshev References: <4E611027.6000103@sugarcrm.com> <4E64CC62.1000209@oracle.com> <4E64CE6D.4070508@hristov.com> In-Reply-To: <4E64CE6D.4070508@hristov.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: rtcsinet21.oracle.com [66.248.204.29] X-CT-RefId: str=0001.0A090206.4E64CFF7.0036,ss=1,re=0.000,fgs=0 Subject: SKIIP of FAIL for tests depending on external bugs From: ulf.wendel@oracle.com (Ulf Wendel) Am 05.09.2011 15:28, schrieb Andrey Hristov: > On 09/05/2011 03:19 PM, Ulf Wendel wrote: >> ... always use the latest and greatest. Libmysql bug, exact version >> range is not known to me. Feel free to change the test to be skipped >> during SKIPIF, for example, like this: >> >> require(connect.inc) >> if (!IS_MYSQLND && libmysql_version > ... && libmysql_version < ...) >> die(skip libmysql bug) >> >> At the first look, I can't find a related bug report at bugs.php.net. >> Looks like few people compare PS and non-PS metadata for EXPLAIN in >> their application. > > this is exactly what I mean. If there was a bug in a previous version > and you try to use it, what do you want to see? SKIP or FAIL? I vote Andrey, you are changing topic from MySQL something test failure to test writing in general. IMHO you are raising a general question worth a dedicated discussion thread, something like: "If a test depends on external entity, which has a bug, shall the test FAIL or be SKIPPed?" I'd appreciate if this is discussed independently of the example of a mysqli test failure discussed in the light of the upcoming PHP 5.4 beta. Ulf