Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55215
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.153 as permitted sender)
Message-ID: <4E649DCA.2010300@sugarcrm.com>
Date: Mon, 05 Sep 2011 03:00:42 -0700
Organization: SugarCRM
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0.1) Gecko/20110830 Thunderbird/6.0.1
MIME-Version: 1.0
To: Ulf Wendel <ulf.wendel@oracle.com>
CC: "internals@lists.php.net" <internals@lists.php.net>
References: <4E611027.6000103@sugarcrm.com> <4E630027.9030502@sugarcrm.com> <4E649696.8090602@oracle.com> <4E64984C.8020900@sugarcrm.com> <4E649B3F.8010203@oracle.com>
In-Reply-To: <4E649B3F.8010203@oracle.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: mysqli tests breaking
From: smalyshev@sugarcrm.com (Stas Malyshev)

Hi!

On 9/5/11 2:49 AM, Ulf Wendel wrote:
> Returning a relevant value for stmt_num_rows() seems a valid feature
> request that makes perfectly sense to me and is somewhat in line with
> the vague non-PS documentation of the case.

It's not a good situation where mysqlnd and libmysql have different 
semantics and people are encouraged to rely on it (if you call it 
feature, you encourage people to use it, otherwise why call it 
feature?). It leads to code that works on mysqnd but not on libmysql, 
without any indication of it - you'll just install an app, and it would 
work on one server but not on the other, for unknown reason. But if you 
add it at least it should be clearly documented - both in the manual and 
in the tests - that this is a non-portable mysqnd-only semantics. And 
the tests should be changed accordingly, so libmysql won't fail.

> To the end user the message is "undefined, do not rely on". Towards the
> library implementor the message is "try to make libmysql become better
> in the future, keep reasonable value in mysqlnd implementation meanwhile".
>
> Do something like:
>
>    if ($IS_MYSQLND)
>       /* TO END USER: no promise on this assumption */
>       ...
>
> Please, do not drop the information of the difference by removal of the
> assertion.

OK, please make the patch yourself, so it looks as you prefer.
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227