Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55214
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain oracle.com from 148.87.113.117 cause and error)
Message-ID: <4E649B3F.8010203@oracle.com>
Date: Mon, 05 Sep 2011 11:49:51 +0200
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:6.0.1) Gecko/20110830 Thunderbird/6.0.1
MIME-Version: 1.0
CC: "internals@lists.php.net" <internals@lists.php.net>
References: <4E611027.6000103@sugarcrm.com> <4E630027.9030502@sugarcrm.com> <4E649696.8090602@oracle.com> <4E64984C.8020900@sugarcrm.com>
In-Reply-To: <4E64984C.8020900@sugarcrm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: mysqli tests breaking
From: ulf.wendel@oracle.com (Ulf Wendel)

Am 05.09.2011 11:37, schrieb Stas Malyshev:
> Hi!
>
> On 9/5/11 2:29 AM, Ulf Wendel wrote:
>> - BC breakage is impossible because behavior is undefined
>> - update test, issue gone
>
> OK, since you say it's not the intended behavior to be relied upon, I'll
> remove this check from the test (if nobody beats me to it).

No, please don't change it that way.

Returning a relevant value for stmt_num_rows() seems a valid feature 
request that makes perfectly sense to me and is somewhat in line with 
the vague non-PS documentation of the case.

To the end user the message is "undefined, do not rely on". Towards the 
library implementor the message is "try to make libmysql become better 
in the future, keep reasonable value in mysqlnd implementation meanwhile".

Do something like:

  if ($IS_MYSQLND)
     /* TO END USER: no promise on this assumption */
     ...

Please, do not drop the information of the difference by removal of the 
assertion.



Ulf