Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55198
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.153 as permitted sender)
Message-ID: <4E63BE89.7030008@sugarcrm.com>
Date: Sun, 04 Sep 2011 11:08:09 -0700
Organization: SugarCRM
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0.1) Gecko/20110830 Thunderbird/6.0.1
MIME-Version: 1.0
To: Pierre Joye <pierre.php@gmail.com>
CC: "internals@lists.php.net" <internals@lists.php.net>
References: <1314966424.2150.26.camel@guybrush> <4E60F712.4010901@lerdorf.com>	<4E612BBA.2000509@oracle.com> <4E612D70.70606@sugarcrm.com>	<4E616A8E.8040401@lerdorf.com> <4E617B3F.4080105@sugarcrm.com>	<4E617C9B.1040504@lerdorf.com> <4E617E2B.7070507@sugarcrm.com>	<4E618811.4010703@lerdorf.com> <4E630091.4070009@sugarcrm.com>	<4E634143.3010907@thelounge.net> <4E6345D9.4070807@sugarcrm.com> <CAEZPtU4DrY58=5JOi9kz=d7TRgWu4NTOd5EDRy0D+9NvmUBYbA@mail.gmail.com> <4E635176.9000406@sugarcrm.com> <CAEZPtU73xvY7Kiu16Puc0wGs5fgYrK52Re-3tJNk9PRo5thofg@mail.gmail.com> <CAEZPtU71ZdB0W=xd==2d-yHOjFWz+0fy7KTiBO+buzhv4KBqwg@mail.gmail.com> <4E63BAE7.90208@sugarcrm.com> <CAEZPtU5_5-qGc5b84UCxucAENS+942ggvaLACLRtaoo9kbvE-g@mail.gmail.com>
In-Reply-To: <CAEZPtU5_5-qGc5b84UCxucAENS+942ggvaLACLRtaoo9kbvE-g@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4
From: smalyshev@sugarcrm.com (Stas Malyshev)

Hi!

On 9/4/11 10:59 AM, Pierre Joye wrote:
> No, just like what I said for the is_a change, but it was acceptable
> for is_a, right? is_a actually broken many (many) apps and codes out
> there and it was easily identified, and it was even acceptable in a
> patch release. Go figure.

Please do not drag totally unrelated matters into the discussion. It 
serves absolutely no purpose.

> Look at the history for the mysql's bugs, plenty of them, internally
> or in userland.

OK, look at them and? What you want me to see there?

> Can you please, and seriously, that's my last attempt, read my answers
> and see what we actually test? I never claimed that nobody uses this
> behavior but I cannot find any code, app or framework failing with
> mysqlnd. Please find one and I will change my mind.

You said "I cannot find any code out there relying on this test case and 
I very much doubt there is any.". This means you're claiming we're 
testing behavior for which there's no code out there - if your guesses 
reflect the truth - that is using it. I think you're wrong but that's 
exactly what you said.

> Btw, I have seen many totally pointless tests written for the sake of
> having a better code coverage while the code itself makes absolutely
> no sense or could even represent something that should not work this
> way in the 1st place.

It is true, but this test actually proved useful - it discovered 
difference in semantics between mysqlnd and libmysql, and in frequently 
used functions at that. Now we know it and we have to decide what to do 
with it. I hope once the weekend is over, mysqlnd maintainers would 
voice their opinions on the matter - e.g., should it work this way or 
not. That's exactly what I want to achieve.
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227