Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:55196 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 70410 invoked from network); 4 Sep 2011 17:59:45 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 4 Sep 2011 17:59:45 -0000 Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.170 as permitted sender) X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.161.170 mail-gx0-f170.google.com Received: from [209.85.161.170] ([209.85.161.170:53709] helo=mail-gx0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 7A/C3-34132-E8CB36E4 for ; Sun, 04 Sep 2011 13:59:43 -0400 Received: by gxk27 with SMTP id 27so3203591gxk.29 for ; Sun, 04 Sep 2011 10:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=c3W/NLgAnfzKpi924wV+GpPt8GSS4SQiU6JwQc2Y8D0=; b=Rp62UMAKr/zcb6UbxpkP1mX+N4z0SVaBFNyC3Yg3iud5g0Ae1HW02yg1PS5vnN8ddo PwzhOOyhkWyv6CAFMzzJcptgIqTZWxu97xHPurRVEA81FxPQRR5WF/R9X0hV3MgypiyF 0zbMLWbYM6TXI0mCv3AMX9DDDiuhyuHSaNYM0= MIME-Version: 1.0 Received: by 10.146.225.7 with SMTP id x7mr2188595yag.10.1315159179668; Sun, 04 Sep 2011 10:59:39 -0700 (PDT) Received: by 10.147.182.15 with HTTP; Sun, 4 Sep 2011 10:59:39 -0700 (PDT) In-Reply-To: <4E63BAE7.90208@sugarcrm.com> References: <1314966424.2150.26.camel@guybrush> <4E60F712.4010901@lerdorf.com> <4E612BBA.2000509@oracle.com> <4E612D70.70606@sugarcrm.com> <4E616A8E.8040401@lerdorf.com> <4E617B3F.4080105@sugarcrm.com> <4E617C9B.1040504@lerdorf.com> <4E617E2B.7070507@sugarcrm.com> <4E618811.4010703@lerdorf.com> <4E630091.4070009@sugarcrm.com> <4E634143.3010907@thelounge.net> <4E6345D9.4070807@sugarcrm.com> <4E635176.9000406@sugarcrm.com> <4E63BAE7.90208@sugarcrm.com> Date: Sun, 4 Sep 2011 19:59:39 +0200 Message-ID: To: Stas Malyshev Cc: "internals@lists.php.net" Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [PHP-DEV] Make mysqlnd default over libmysql in 5.4 From: pierre.php@gmail.com (Pierre Joye) hi, On Sun, Sep 4, 2011 at 7:52 PM, Stas Malyshev wrote: > So you're saying breaking BC is OK if only you can find some unaffected > applications, right? No, just like what I said for the is_a change, but it was acceptable for is_a, right? is_a actually broken many (many) apps and codes out there and it was easily identified, and it was even acceptable in a patch release. Go figure. >> There are incimoatibilities too across libmysql versions and across >> mysql servers, which are actually affecting existing codes. > > I don't know of any incompatibilities that change semantics on this level, > and anyway libmysql is beyond our control, but mysqlnd isn't. Look at the history for the mysql's bugs, plenty of them, internally or in userland. >> I cannot find any code out there relying on this test case and I very >> much doubt there is any. It is a non issue (unlike the is_a change for >> example). > > Why we're testing for functions that, as you claim, nobody ever uses? Can you please, and seriously, that's my last attempt, read my answers and see what we actually test? I never claimed that nobody uses this behavior but I cannot find any code, app or framework failing with mysqlnd. Please find one and I will change my mind. Btw, I have seen many totally pointless tests written for the sake of having a better code coverage while the code itself makes absolutely no sense or could even represent something that should not work this way in the 1st place. Cheers, -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org