Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55103
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.113 as permitted sender)
Message-ID: <4E61379A.6000005@sugarcrm.com>
Date: Fri, 02 Sep 2011 13:07:54 -0700
Organization: SugarCRM
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0.1) Gecko/20110830 Thunderbird/6.0.1
MIME-Version: 1.0
To: Ulf Wendel <ulf.wendel@phpdoc.de>
CC: PHP Internals <internals@lists.php.net>
References: <4E611027.6000103@sugarcrm.com> <4E611A8E.5080108@phpdoc.de> <4E612003.6020303@sugarcrm.com> <4E612A4C.7080707@phpdoc.de>
In-Reply-To: <4E612A4C.7080707@phpdoc.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [SPAM?]:  Re: [PHP-DEV] mysqli tests breaking
From: smalyshev@sugarcrm.com (Stas Malyshev)

Hi!

On 9/2/11 12:11 PM, Ulf Wendel wrote:
> This is no more than a friendly request to check against latest and
> greatest to avoid hitting bugs already fixed in libmysql. Latest GA is
> 5.1.58, if I'm not mistaken,
> http://dev.mysql.com/downloads/mysql/5.1.html . You are testing again
> 5.1.4x. Generally speaking, libmysql 5.1.4x won't see updates, just like
> PHP 5.2 won't.

While it is a good advice in general, I seriously doubt the semantics of 
mysql_num_rows() or last_insert_id() SQL statement changed between 
5.1.4x and 5.1.5x. That would be serious and profound change totally 
inaproppriate for such version and my quick check of the changelogs 
suggests nothing of the sort. So I'm afraid there's little hope that the 
failures I am observing are caused by not using 5.1.5x.

> Regarding test portability ... you probably can imagine how annoyed I
> have been when orginally writing tests and hitting non portable stuff,
> deperately trying to actually test for something.

I agree it is annoying, but we have to sort it out nevertheless. If we 
have tests that work only on some specific versions and break on others, 
we need either to identify breakage point and have them specifically 
pointed out (such as: "This test won't work on versions before X.Y.Z 
because mysql_foo_bar() function returns wrong value in foobar 
structure") and if possible, skipped out with informative message. 
Otherwise for any user that doesn't run exactly the same library version 
as test developer ran, the test suite doesn't work - he doesn't have the 
means to identify if something is wrong or not.
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227