Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:55094 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 45442 invoked from network); 2 Sep 2011 18:27:22 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Sep 2011 18:27:22 -0000 Authentication-Results: pb1.pair.com header.from=smalyshev@sugarcrm.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=smalyshev@sugarcrm.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain sugarcrm.com designates 67.192.241.123 as permitted sender) X-PHP-List-Original-Sender: smalyshev@sugarcrm.com X-Host-Fingerprint: 67.192.241.123 smtp123.dfw.emailsrvr.com Linux 2.6 Received: from [67.192.241.123] ([67.192.241.123:50796] helo=smtp123.dfw.emailsrvr.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 7B/02-31460-800216E4 for ; Fri, 02 Sep 2011 14:27:21 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp12.relay.dfw1a.emailsrvr.com (SMTP Server) with ESMTP id CA0193C010D; Fri, 2 Sep 2011 14:27:17 -0400 (EDT) X-Virus-Scanned: OK Received: by smtp12.relay.dfw1a.emailsrvr.com (Authenticated sender: smalyshev-AT-sugarcrm.com) with ESMTPSA id 667843C020D; Fri, 2 Sep 2011 14:27:17 -0400 (EDT) Message-ID: <4E612003.6020303@sugarcrm.com> Date: Fri, 02 Sep 2011 11:27:15 -0700 Organization: SugarCRM User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:6.0.1) Gecko/20110830 Thunderbird/6.0.1 MIME-Version: 1.0 To: Ulf Wendel CC: PHP Internals References: <4E611027.6000103@sugarcrm.com> <4E611A8E.5080108@phpdoc.de> In-Reply-To: <4E611A8E.5080108@phpdoc.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] mysqli tests breaking From: smalyshev@sugarcrm.com (Stas Malyshev) Hi! On 9/2/11 11:03 AM, Ulf Wendel wrote: > please, always test against the latest and greatest. Otherwise you'll be > testing against libmysql versions that are not going to see any updates. 5.1 is still a supported version of Mysql. It is run on many production servers, so I think we must support it - it's no use to run tests on the bleeding edge versions while production runs different ones. And production DB servers are upgraded very rarely, especially since 5.1 is still supported and good enough for many users. Having tests that run only on one version is next to useless, since that means I'd never know if the code actually works in production - which is the point of having the tests! If some specific test tests some fix that available only since specific version - the test must be marked as such and be skipped or disable the missing function in version that is too old. I'm not saying we should support all Mysql versions since the start of the project - but I do not see how 5.1 can be excluded. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227