Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:55082 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 98015 invoked from network); 2 Sep 2011 11:33:09 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 2 Sep 2011 11:33:09 -0000 Authentication-Results: pb1.pair.com header.from=ekneuss@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=ekneuss@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.214.42 as permitted sender) X-PHP-List-Original-Sender: ekneuss@gmail.com X-Host-Fingerprint: 209.85.214.42 mail-bw0-f42.google.com Received: from [209.85.214.42] ([209.85.214.42:48306] helo=mail-bw0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 68/01-25695-3FEB06E4 for ; Fri, 02 Sep 2011 07:33:08 -0400 Received: by bkas6 with SMTP id s6so2244907bka.29 for ; Fri, 02 Sep 2011 04:33:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=9OP4AO4UXMb3GDzxxYkYKqlSPUlM8WevJE/PDXeEWM0=; b=Wz/OnxHhPWnsUdUEA9dX4Lm8psX0sgrSU5neuZktCpVlzZGPFSat5GJtQIFX3H2+Vb IiA/DwNF3OiI+DHaeR+kJPCb4eEaFEC3QQH+JrbinckVg8lP3jBOOxALvsDdh44l07NH mourMdeSZbmKi1siAtT57awezlHUlO3VjxX6s= MIME-Version: 1.0 Received: by 10.204.134.3 with SMTP id h3mr548080bkt.402.1314963183244; Fri, 02 Sep 2011 04:33:03 -0700 (PDT) Sender: ekneuss@gmail.com Received: by 10.204.40.199 with HTTP; Fri, 2 Sep 2011 04:33:03 -0700 (PDT) In-Reply-To: <000001cc6963$39c93c30$ad5bb490$@com> References: <1314115682.2635.98.camel@guybrush> <4E545A6C.60704@akbkhome.com> <4E54C658.6070209@akbkhome.com> <887FE7CFF6F8DE4BB3A9535F53AFD06A495AAA2F@il-ex2.zend.net> <887FE7CFF6F8DE4BB3A9535F53AFD06A495AAE17@il-ex2.zend.net> <887FE7CFF6F8DE4BB3A9535F53AFD06A495AB00F@il-ex2.zend.net> <887FE7CFF6F8DE4BB3A9535F53AFD06A495AB153@il-ex2.zend.net> <4E54F0D6.9030005@akbkhome.com> <000001cc6963$39c93c30$ad5bb490$@com> Date: Fri, 2 Sep 2011 13:33:03 +0200 X-Google-Sender-Auth: -RDJeooWC9Bp2KnrmANBLBygy2I Message-ID: To: Jonathan Bond-Caron Cc: Pierre Joye , alan@akbkhome.com, Zeev Suraski , internals@lists.php.net Content-Type: multipart/alternative; boundary=000e0ce0b1c06e172f04abf3b945 Subject: Re: [PHP-DEV] PHP 5.3.8 Released! From: colder@php.net (Etienne Kneuss) --000e0ce0b1c06e172f04abf3b945 Content-Type: text/plain; charset=UTF-8 Hi, On Fri, Sep 2, 2011 at 13:26, Jonathan Bond-Caron wrote: > On Wed Aug 24 08:42 AM, Pierre Joye wrote: > > Hi Alan, > > > > the breakage is about is_a with a string as 1st argument, not is_a as > > a whole. So yes, it breaks is_a alone is used as validation. > > > > I've been digging more into this: > > http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/Zend/zend_builtin_fun > ctions.c?r1=307522&r2=312904&pathrev=312904 > > From what I understand, this patch is only place where is_a() all of sudden > starts accepting a string. > Btw the documentation has never been updated: > http://php.net/manual/en/function.is-a.php > > It seems unintentional, the patch tries to fix a bug but introduces a new > 'feature'. Should it be reverted? > We already discussed that *in length* the past couple of weeks, the patch was in fact intentional and we decided not to revert it. Best, > > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Etienne Kneuss http://www.colder.ch --000e0ce0b1c06e172f04abf3b945--