Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55081
Return-Path: <jbondc@openmv.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 96095 invoked from network); 2 Sep 2011 11:27:05 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 2 Sep 2011 11:27:05 -0000
Authentication-Results: pb1.pair.com smtp.mail=jbondc@openmv.com; spf=permerror; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=jbondc@openmv.com; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain openmv.com from 64.15.152.204 cause and error)
X-PHP-List-Original-Sender: jbondc@openmv.com
X-Host-Fingerprint: 64.15.152.204 mail.ca.gdesolutions.com  
Received: from [64.15.152.204] ([64.15.152.204:58671] helo=mail.ca.gdesolutions.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 18/A0-25695-68DB06E4 for <internals@lists.php.net>; Fri, 02 Sep 2011 07:27:03 -0400
Received: from localhost (localhost [127.0.0.1])
	by mail.ca.gdesolutions.com (Postfix) with ESMTP id 1E2455D18;
	Fri,  2 Sep 2011 07:26:59 -0400 (EDT)
X-Virus-Scanned: amavisd-new at gdesolutions.com
Received: from mail.ca.gdesolutions.com ([127.0.0.1])
	by localhost (mail.ca.gdesolutions.com [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 6w97XBCSefep; Fri,  2 Sep 2011 07:26:58 -0400 (EDT)
Received: from djbondc (modemcable166.116-70-69.static.videotron.ca [69.70.116.166])
	by mail.ca.gdesolutions.com (Postfix) with ESMTPSA id 0DCFD5D14;
	Fri,  2 Sep 2011 07:26:57 -0400 (EDT)
To: "'Pierre Joye'" <pierre.php@gmail.com>,
	<alan@akbkhome.com>
Cc: "'Zeev Suraski'" <zeev@zend.com>,
	<internals@lists.php.net>
References: <1314115682.2635.98.camel@guybrush>	<4E545A6C.60704@akbkhome.com>	<CAH-PCH5jyEQZvwgqxkUpqN7a-VUc+nYt=_ixFQ1si64xxMBw4A@mail.gmail.com>	<4E54C658.6070209@akbkhome.com>	<887FE7CFF6F8DE4BB3A9535F53AFD06A495AAA2F@il-ex2.zend.net>	<CAEZPtU4TQ_-FnrqosWfLx8xvQvgtPi2BnhkV3o=J43056Lxoeg@mail.gmail.com>	<887FE7CFF6F8DE4BB3A9535F53AFD06A495AAE17@il-ex2.zend.net>	<CAEZPtU5Hy6rqbj0DMVg+HhJ2yMoSA2O4ErNpwbe0JuKc0t=jrw@mail.gmail.com>	<887FE7CFF6F8DE4BB3A9535F53AFD06A495AB00F@il-ex2.zend.net>	<CAEZPtU7MLoH=vQ2S12keYtPtoQT9fDb9YLQrF4qOSU=iA0M+nw@mail.gmail.com>	<887FE7CFF6F8DE4BB3A9535F53AFD06A495AB153@il-ex2.zend.net>	<4E54F0D6.9030005@akbkhome.com> <CAEZPtU44p7BcCgzsFnKeAdPH+HvUYtmvgO=755ALN+T2Tux=7Q@mail.gmail.com>
In-Reply-To: <CAEZPtU44p7BcCgzsFnKeAdPH+HvUYtmvgO=755ALN+T2Tux=7Q@mail.gmail.com>
Date: Fri, 2 Sep 2011 07:26:57 -0400
Message-ID: <000001cc6963$39c93c30$ad5bb490$@com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Office Outlook 12.0
Thread-Index: AcxiW3FXbrCDiceXT2m+LaUccNlP8AHBkLaA
Content-Language: en-ca
Subject: RE: [PHP-DEV] PHP 5.3.8 Released!
From: jbondc@openmv.com ("Jonathan Bond-Caron")

On Wed Aug 24 08:42 AM, Pierre Joye wrote:
> Hi Alan,
> 
> the breakage is about is_a with a string as 1st argument, not is_a as 
> a whole. So yes, it breaks is_a alone is used as validation.
> 

I've been digging more into this:
http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/Zend/zend_builtin_fun
ctions.c?r1=307522&r2=312904&pathrev=312904

From what I understand, this patch is only place where is_a() all of sudden
starts accepting a string.
Btw the documentation has never been updated:
http://php.net/manual/en/function.is-a.php

It seems unintentional, the patch tries to fix a bug but introduces a new
'feature'. Should it be reverted?