Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55075
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CADNQb0WqERoZuVOs43E7YEXxp0avUYx9Hugrcy1dZpJvutgtmg@mail.gmail.com>
References: <CAEZPtU60Ob_Tqs82-+B2c17Lg1SAtj29HJc_mLUbBZRyLQf+mQ@mail.gmail.com>
	<CADNQb0WqERoZuVOs43E7YEXxp0avUYx9Hugrcy1dZpJvutgtmg@mail.gmail.com>
Date: Fri, 2 Sep 2011 00:04:38 +0200
Message-ID: <CAH-PCH53VAUAqy5=2bS-EAqkEavLc0EBZy3-+0o1qMbQ0J+nag@mail.gmail.com>
To: Hannes Magnusson <hannes.magnusson@gmail.com>
Cc: Pierre Joye <pierre.php@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: drop bison 1.x?
From: tyra3l@gmail.com (Ferenc Kovacs)

On Thu, Sep 1, 2011 at 10:54 PM, Hannes Magnusson
<hannes.magnusson@gmail.com> wrote:
> On Thu, Sep 1, 2011 at 20:58, Pierre Joye <pierre.php@gmail.com> wrote:
>> Please show me one system relying on it?=C2=A0 13 years old...
>>
>
> Your own test box before Rasmus pointed it out to you when you where
> changing the tests.
>
> Forcing people to upgrade this kind of software between bugfix
> releases doesn't give us anything other then annoyed users.
>
>
>> Even if the plan is to drop it in 5.4+ for now.
>
> Fair enough.
>
>
>> And yes the diff in the messages make testing harder as it should be. Ot=
her
>> would have noticed it already as many tests fail because of that.
>
> So it works just fine? There are no security or related bugs in the
> older versions? Or even performance reasons?
>
> There is no reason for us to test error messages from third party
> software, and it doesn't cost us any more work to support it..
>
> -Hannes
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>

I'm not sure that I understand this correctly, so let me ask this:
Pierre do you want to change this because of this two broken tests:
http://news.php.net/php.internals/55048 ?
AFAIK it isn't directly related to different versions of bison, but to
this change in 5.4 :
https://wiki.php.net/rfc/improved-parser-error-message
and yes, this means that we have to support a diverging set of tests
for those cases when the test depends on the parse error messages.
I think it is safe to revert your changes for those two tests in the 5.3 br=
anch.

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu