Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55041
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.54 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4E5DB4E8.4030509@lerdorf.com>
References: <4E5DACD6.1000002@sugarcrm.com>
	<4E5DB4E8.4030509@lerdorf.com>
Date: Wed, 31 Aug 2011 19:48:03 +0800
Message-ID: <CAHMUw2ENmudmBP2Wx_qsZiThJs1aDf9SKLM-saujqPFB3KmdeQ@mail.gmail.com>
To: Rasmus Lerdorf <rasmus@lerdorf.com>
Cc: jeraimee@php.net, PHP Internals <internals@lists.php.net>, 
	Stas Malyshev <smalyshev@sugarcrm.com>
Content-Type: multipart/alternative; boundary=0016364994cd6c28c204abcbb31a
Subject: Re: [PHP-DEV] 5.4 beta & tests
From: tjerk.meesters@gmail.com (Tjerk Meesters)

--0016364994cd6c28c204abcbb31a
Content-Type: text/plain; charset=ISO-8859-1

On Aug 31, 2011 12:14 PM, "Rasmus Lerdorf" <rasmus@lerdorf.com> wrote:
>
> On 08/30/2011 08:39 PM, Stas Malyshev wrote:
> > Hi!
> >
> > I've checked the unit tests on my Mac and I see 48 failures so far. I've
> > put them here:
> > https://wiki.php.net/todo/tests54?&#tested_2011-08-30_on_mac_os_x
> >
> > Most of them are mysql, but others too.
> > So, is there anybody working or willing to work to fix them all for
> > beta? Should we postpone the beta for a week to wait for that or it
> > doesn't make difference?
>
> I say we postpone. We really need to get used to the fact that failing
> tests matter and that they block releases.
>
> Why is your tests/func/005a.phpt failing? That seems to pass
> consistently for most people.
>
> tests/lang/045.phpt is the one that fails for everyone because we don't
> re-apply the timeout for a registered shutdown function. We should
> either fix that or mark it as an XFAIL.

The timeout gets applied but the SIG_ALARM gets filtered by the signal
handler because SIGG(running) is still true. Setting running to false inside
zend_timeout before calling the other functions seems a (hack?) solution.

>
> The two openbasedir tests were broken by these commits:
>
>
http://svn.php.net/viewvc/php/php-src/branches/PHP_5_4/tests/security/open_basedir_linkinfo.phpt?r1=311033&r2=311509
>
>
http://svn.php.net/viewvc/php/php-src/branches/PHP_5_4/tests/security/open_basedir_readlink.phpt?r1=311033&r2=311507
>
> which you merged from trunk based on changes by jeraimee:
>
>
http://svn.php.net/viewvc/php/php-src/trunk/tests/security/open_basedir_linkinfo.phpt?r1=296679&r2=311141
>
> so we should figure out why that was changed. I don't think this
> behaviour is difference between trunk and 5.4 so I don't understand the
> change.
>
> ext/date/tests/bug33532.phpt doesn't fail for me. LOCALE differences?
> What is your diff on that one?
>
> I'm not sure how we should attack it, but I think with a little bit of
> discussion on each failing test we can plow through these pretty quickly.
>
> -Rasmus
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>

--0016364994cd6c28c204abcbb31a--