Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:55038 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 3081 invoked from network); 31 Aug 2011 11:32:53 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 31 Aug 2011 11:32:53 -0000 Authentication-Results: pb1.pair.com smtp.mail=ilia@prohost.org; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=ilia@prohost.org; sender-id=pass Received-SPF: pass (pb1.pair.com: domain prohost.org designates 209.85.214.42 as permitted sender) X-PHP-List-Original-Sender: ilia@prohost.org X-Host-Fingerprint: 209.85.214.42 mail-bw0-f42.google.com Received: from [209.85.214.42] ([209.85.214.42:56836] helo=mail-bw0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 51/F0-30996-3EB1E5E4 for ; Wed, 31 Aug 2011 07:32:52 -0400 Received: by bkas6 with SMTP id s6so425701bka.29 for ; Wed, 31 Aug 2011 04:32:48 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.128.80 with SMTP id j16mr204673bks.9.1314790368172; Wed, 31 Aug 2011 04:32:48 -0700 (PDT) Received: by 10.204.130.198 with HTTP; Wed, 31 Aug 2011 04:32:48 -0700 (PDT) In-Reply-To: <4E5E13D5.7010808@liip.ch> References: <4E5DACD6.1000002@sugarcrm.com> <4E5DE728.9090207@sugarcrm.com> <4E5E014E.3060105@liip.ch> <4E5E0621.607@liip.ch> <4E5E13D5.7010808@liip.ch> Date: Wed, 31 Aug 2011 07:32:48 -0400 Message-ID: To: Christian Stocker Cc: Laruence , Stas Malyshev , PHP Internals Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] 5.4 beta & tests From: ilia@prohost.org (Ilia Alshanetsky) Revert sounds find to me, the change was indeed to fix the test. On Wed, Aug 31, 2011 at 6:58 AM, Christian Stocker wrote: > > > On 31.08.11 12:25, Laruence wrote: >> Hi: >> =A0 =A0 I think you should not commit untill ask ilia for the reason of >> previous change, > > sure, but my guess is he just fixed the code to pass the test, but IMHO > the test was wrong (and my patches fixes that). ilia? > > chregu >> >> thanks >> >> 2011/8/31 Christian Stocker : >>> Hi >>> >>> Here's my proposed patch >>> https://gist.github.com/1183212 >>> >>> If noone objects, I'll commit it soon >>> >>> chregu >>> >>> On 31.08.11 11:39, Christian Stocker wrote: >>>> >>>> >>>> On 31.08.11 09:47, Stas Malyshev wrote: >>>>> Hi! >>>>> >>>>> For simplexml test (ext/simplexml/tests/bug48601.phpt), it looks like >>>>> Ilia reverted the fix for bug #48601 with this: >>>>> >>>>> http://svn.php.net/viewvc/php/php-src/branches/PHP_5_4/ext/simplexml/= simplexml.c?r1=3D311870&r2=3D311874 >>>>> >>>>> >>>>> I'm not sure what simplexml is supposed to return in each case, the >>>>> tests seem to be contradictory. Anybody knows what is the right thing= to >>>>> do here? >>>> >>>> Ilia fixed test 0008.phpt with that, but for some reason an XPath of >>>> "***" isn't considered invalid by libxml (but "**" is, don't ask me wh= y >>>> ;)). I'd say if libxml doesn't think the XPath expression is invalid, = we >>>> should return an empty array and not false. With DOM exactly that happ= ens. >>>> >>>> I therefore vote for reverting Ilia's patch mentioned above. >>>> >>>> chregu >>>> >>>> >>> >>> -- >>> Liip AG =A0// =A0Feldstrasse 133 // =A0CH-8004 Zurich >>> Tel +41 43 500 39 81 // Mobile +41 76 561 88 60 >>> www.liip.ch // blog.liip.ch // GnuPG 0x0748D5FE >>> >>> >>> -- >>> PHP Internals - PHP Runtime Development Mailing List >>> To unsubscribe, visit: http://www.php.net/unsub.php >>> >>> >> >> >> > > -- > Liip AG =A0// =A0Feldstrasse 133 // =A0CH-8004 Zurich > Tel +41 43 500 39 81 // Mobile +41 76 561 88 60 > www.liip.ch // blog.liip.ch // GnuPG 0x0748D5FE > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > >