Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55037
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain liip.ch designates 207.126.144.133 as permitted sender)
Message-ID: <4E5E13D5.7010808@liip.ch>
Date: Wed, 31 Aug 2011 12:58:29 +0200
Organization: Liip AG
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:6.0) Gecko/20110812 Thunderbird/6.0
MIME-Version: 1.0
To: Laruence <laruence@php.net>
CC: Stas Malyshev <smalyshev@sugarcrm.com>, 
 PHP Internals <internals@lists.php.net>
References: <4E5DACD6.1000002@sugarcrm.com> <4E5DE728.9090207@sugarcrm.com> <4E5E014E.3060105@liip.ch> <4E5E0621.607@liip.ch> <CABBJUpfhWFQUFQtXTh+T0cc7-QzkL4Ek=U2p2Dm8WuNGoUgi9A@mail.gmail.com>
In-Reply-To: <CABBJUpfhWFQUFQtXTh+T0cc7-QzkL4Ek=U2p2Dm8WuNGoUgi9A@mail.gmail.com>
OpenPGP: id=0748D5FE;
	url=http://gpg-keyserver.de/pks/lookup?op=get&search=0xC2BAFBC30748D5FE
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] 5.4 beta & tests
From: christian.stocker@liip.ch (Christian Stocker)



On 31.08.11 12:25, Laruence wrote:
> Hi:
>     I think you should not commit untill ask ilia for the reason of
> previous change,

sure, but my guess is he just fixed the code to pass the test, but IMHO
the test was wrong (and my patches fixes that). ilia?

chregu
> 
> thanks
> 
> 2011/8/31 Christian Stocker <christian.stocker@liip.ch>:
>> Hi
>>
>> Here's my proposed patch
>> https://gist.github.com/1183212
>>
>> If noone objects, I'll commit it soon
>>
>> chregu
>>
>> On 31.08.11 11:39, Christian Stocker wrote:
>>>
>>>
>>> On 31.08.11 09:47, Stas Malyshev wrote:
>>>> Hi!
>>>>
>>>> For simplexml test (ext/simplexml/tests/bug48601.phpt), it looks like
>>>> Ilia reverted the fix for bug #48601 with this:
>>>>
>>>> http://svn.php.net/viewvc/php/php-src/branches/PHP_5_4/ext/simplexml/simplexml.c?r1=311870&r2=311874
>>>>
>>>>
>>>> I'm not sure what simplexml is supposed to return in each case, the
>>>> tests seem to be contradictory. Anybody knows what is the right thing to
>>>> do here?
>>>
>>> Ilia fixed test 0008.phpt with that, but for some reason an XPath of
>>> "***" isn't considered invalid by libxml (but "**" is, don't ask me why
>>> ;)). I'd say if libxml doesn't think the XPath expression is invalid, we
>>> should return an empty array and not false. With DOM exactly that happens.
>>>
>>> I therefore vote for reverting Ilia's patch mentioned above.
>>>
>>> chregu
>>>
>>>
>>
>> --
>> Liip AG  //  Feldstrasse 133 //  CH-8004 Zurich
>> Tel +41 43 500 39 81 // Mobile +41 76 561 88 60
>> www.liip.ch // blog.liip.ch // GnuPG 0x0748D5FE
>>
>>
>> --
>> PHP Internals - PHP Runtime Development Mailing List
>> To unsubscribe, visit: http://www.php.net/unsub.php
>>
>>
> 
> 
> 

-- 
Liip AG  //  Feldstrasse 133 //  CH-8004 Zurich
Tel +41 43 500 39 81 // Mobile +41 76 561 88 60
www.liip.ch // blog.liip.ch // GnuPG 0x0748D5FE