Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:55036 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 92730 invoked from network); 31 Aug 2011 10:25:20 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 31 Aug 2011 10:25:20 -0000 Authentication-Results: pb1.pair.com smtp.mail=laruence@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=laruence@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.42 as permitted sender) X-PHP-List-Original-Sender: laruence@gmail.com X-Host-Fingerprint: 209.85.212.42 mail-vw0-f42.google.com Received: from [209.85.212.42] ([209.85.212.42:36185] helo=mail-vw0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 62/A0-23777-B0C0E5E4 for ; Wed, 31 Aug 2011 06:25:15 -0400 Received: by vwl1 with SMTP id 1so451442vwl.29 for ; Wed, 31 Aug 2011 03:25:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=XiQUZJ0KIhmpd/n34uG9k2yoa9fodiUnTFuII6TwRic=; b=O2Wd47IfYyUGSFxT0/EOtWTjc/cyg4GjxLN+HFKw97Bln13hu6Ba1dHuKq5aLhJrXF Wn2sQLcnMOYghTqOSu4KZq4msbks5Xo1UbpdYlQDVwYl7qtT+3xVhgHFTigyd0dEArAt tklfs5xC6h2zxjhcXSnn0ug7+Q1CC/tnE7I0k= MIME-Version: 1.0 Received: by 10.52.185.197 with SMTP id fe5mr204079vdc.6.1314786312269; Wed, 31 Aug 2011 03:25:12 -0700 (PDT) Sender: laruence@gmail.com Received: by 10.220.189.195 with HTTP; Wed, 31 Aug 2011 03:25:12 -0700 (PDT) In-Reply-To: <4E5E0621.607@liip.ch> References: <4E5DACD6.1000002@sugarcrm.com> <4E5DE728.9090207@sugarcrm.com> <4E5E014E.3060105@liip.ch> <4E5E0621.607@liip.ch> Date: Wed, 31 Aug 2011 18:25:12 +0800 X-Google-Sender-Auth: _m9zJJ0_NmNvMEXxrL3-L9sePO4 Message-ID: To: Christian Stocker Cc: Stas Malyshev , PHP Internals Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] 5.4 beta & tests From: laruence@php.net (Laruence) Hi: I think you should not commit untill ask ilia for the reason of previous change, thanks 2011/8/31 Christian Stocker : > Hi > > Here's my proposed patch > https://gist.github.com/1183212 > > If noone objects, I'll commit it soon > > chregu > > On 31.08.11 11:39, Christian Stocker wrote: >> >> >> On 31.08.11 09:47, Stas Malyshev wrote: >>> Hi! >>> >>> For simplexml test (ext/simplexml/tests/bug48601.phpt), it looks like >>> Ilia reverted the fix for bug #48601 with this: >>> >>> http://svn.php.net/viewvc/php/php-src/branches/PHP_5_4/ext/simplexml/si= mplexml.c?r1=3D311870&r2=3D311874 >>> >>> >>> I'm not sure what simplexml is supposed to return in each case, the >>> tests seem to be contradictory. Anybody knows what is the right thing t= o >>> do here? >> >> Ilia fixed test 0008.phpt with that, but for some reason an XPath of >> "***" isn't considered invalid by libxml (but "**" is, don't ask me why >> ;)). I'd say if libxml doesn't think the XPath expression is invalid, we >> should return an empty array and not false. With DOM exactly that happen= s. >> >> I therefore vote for reverting Ilia's patch mentioned above. >> >> chregu >> >> > > -- > Liip AG =C2=A0// =C2=A0Feldstrasse 133 // =C2=A0CH-8004 Zurich > Tel +41 43 500 39 81 // Mobile +41 76 561 88 60 > www.liip.ch // blog.liip.ch // GnuPG 0x0748D5FE > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > --=20 Laruence =C2=A0Xinchen Hui http://www.laruence.com/