Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:55034 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 88018 invoked from network); 31 Aug 2011 10:00:23 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 31 Aug 2011 10:00:23 -0000 Authentication-Results: pb1.pair.com header.from=christian.stocker@liip.ch; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=christian.stocker@liip.ch; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain liip.ch designates 207.126.144.143 as permitted sender) X-PHP-List-Original-Sender: christian.stocker@liip.ch X-Host-Fingerprint: 207.126.144.143 eu1sys200aog117.obsmtp.com Linux 2.5 (sometimes 2.4) (4) Received: from [207.126.144.143] ([207.126.144.143:58139] helo=eu1sys200aog117.obsmtp.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 98/83-03558-0360E5E4 for ; Wed, 31 Aug 2011 06:00:22 -0400 Received: from mail-ey0-f172.google.com ([209.85.215.172]) (using TLSv1) by eu1sys200aob117.postini.com ([207.126.147.11]) with SMTP ID DSNKTl4GJWbVvlvj7M3PfH5qtnrt2ckqXIQt@postini.com; Wed, 31 Aug 2011 10:00:21 UTC Received: by mail-ey0-f172.google.com with SMTP id 4so371190eye.31 for ; Wed, 31 Aug 2011 03:00:05 -0700 (PDT) Received: by 10.213.31.68 with SMTP id x4mr157264ebc.24.1314784803807; Wed, 31 Aug 2011 03:00:03 -0700 (PDT) Received: from pri7.local (77-58-253-248.dclient.hispeed.ch [77.58.253.248]) by mx.google.com with ESMTPS id q8sm4474357eea.25.2011.08.31.03.00.02 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 31 Aug 2011 03:00:02 -0700 (PDT) Message-ID: <4E5E0621.607@liip.ch> Date: Wed, 31 Aug 2011 12:00:01 +0200 Organization: Liip AG User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:6.0) Gecko/20110812 Thunderbird/6.0 MIME-Version: 1.0 To: Stas Malyshev CC: PHP Internals References: <4E5DACD6.1000002@sugarcrm.com> <4E5DE728.9090207@sugarcrm.com> <4E5E014E.3060105@liip.ch> In-Reply-To: <4E5E014E.3060105@liip.ch> X-Enigmail-Version: 1.3.1 OpenPGP: id=0748D5FE; url=http://gpg-keyserver.de/pks/lookup?op=get&search=0xC2BAFBC30748D5FE Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] 5.4 beta & tests From: christian.stocker@liip.ch (Christian Stocker) Hi Here's my proposed patch https://gist.github.com/1183212 If noone objects, I'll commit it soon chregu On 31.08.11 11:39, Christian Stocker wrote: > > > On 31.08.11 09:47, Stas Malyshev wrote: >> Hi! >> >> For simplexml test (ext/simplexml/tests/bug48601.phpt), it looks like >> Ilia reverted the fix for bug #48601 with this: >> >> http://svn.php.net/viewvc/php/php-src/branches/PHP_5_4/ext/simplexml/simplexml.c?r1=311870&r2=311874 >> >> >> I'm not sure what simplexml is supposed to return in each case, the >> tests seem to be contradictory. Anybody knows what is the right thing to >> do here? > > Ilia fixed test 0008.phpt with that, but for some reason an XPath of > "***" isn't considered invalid by libxml (but "**" is, don't ask me why > ;)). I'd say if libxml doesn't think the XPath expression is invalid, we > should return an empty array and not false. With DOM exactly that happens. > > I therefore vote for reverting Ilia's patch mentioned above. > > chregu > > -- Liip AG // Feldstrasse 133 // CH-8004 Zurich Tel +41 43 500 39 81 // Mobile +41 76 561 88 60 www.liip.ch // blog.liip.ch // GnuPG 0x0748D5FE