Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55024
Return-Path: <rasmus@lerdorf.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 44322 invoked from network); 31 Aug 2011 05:23:29 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 31 Aug 2011 05:23:29 -0000
Authentication-Results: pb1.pair.com smtp.mail=rasmus@lerdorf.com; spf=permerror; sender-id=unknown
Authentication-Results: pb1.pair.com header.from=rasmus@lerdorf.com; sender-id=unknown
Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.210.170 cause and error)
X-PHP-List-Original-Sender: rasmus@lerdorf.com
X-Host-Fingerprint: 209.85.210.170 mail-iy0-f170.google.com  
Received: from [209.85.210.170] ([209.85.210.170:42910] helo=mail-iy0-f170.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 52/3D-50561-055CD5E4 for <internals@lists.php.net>; Wed, 31 Aug 2011 01:23:28 -0400
Received: by iadk27 with SMTP id k27so530217iad.29
        for <internals@lists.php.net>; Tue, 30 Aug 2011 22:23:25 -0700 (PDT)
Received: by 10.231.66.85 with SMTP id m21mr14867242ibi.53.1314768205117;
        Tue, 30 Aug 2011 22:23:25 -0700 (PDT)
Received: from [192.168.200.5] (c-50-131-46-20.hsd1.ca.comcast.net [50.131.46.20])
        by mx.google.com with ESMTPS id fr1sm1899661ibb.57.2011.08.30.22.23.23
        (version=SSLv3 cipher=OTHER);
        Tue, 30 Aug 2011 22:23:24 -0700 (PDT)
Message-ID: <4E5DC54A.40901@lerdorf.com>
Date: Tue, 30 Aug 2011 22:23:22 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110812 Thunderbird/6.0
MIME-Version: 1.0
To: Stas Malyshev <smalyshev@sugarcrm.com>
CC: PHP Internals <internals@lists.php.net>
References: <4E5DACD6.1000002@sugarcrm.com> <4E5DB4E8.4030509@lerdorf.com> <4E5DBE4A.6010403@sugarcrm.com> <4E5DC1BE.1000800@sugarcrm.com>
In-Reply-To: <4E5DC1BE.1000800@sugarcrm.com>
X-Enigmail-Version: 1.2.1
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] 5.4 beta & tests
From: rasmus@lerdorf.com (Rasmus Lerdorf)

On 08/30/2011 10:08 PM, Stas Malyshev wrote:
> Hi!
> 
> On 8/30/11 9:53 PM, Stas Malyshev wrote:
>> strftime() on Mac seems to ignore timezone arguments in struct tm for
>> some reason and uses environment TZ instead. Not sure how to address
>> that.
> 
> Looking into Mac strftime sources, it says this:
> 
>             ** C99 says that the UTC offset must
>             ** be computed by looking only at
>             ** tm_isdst. This requirement is
>             ** incorrect, since it means the code
>             ** must rely on magic (in this case
>             ** altzone and timezone), and the
>             ** magic might not have the correct
>             ** offset. Doing things correctly is
>             ** tricky and requires disobeying C99;
>             ** see GNU C strftime for details.
>             ** For now, punt and conform to the
>             ** standard, even though it's incorrect.
> 
> Which means, since we can't touch the environment in php_date.c code, we
> have to set TZ env variable for the test to pass, and strftime for Mac
> is dependent on TZ env and we can't do a thing about it as it seems.

Right, so this is an XFAIL test on the Mac I guess, although I don't
think we have any way to indicate a platform-specific XFAIL. So maybe
add a Mac check and make it a SKIP on the Mac.

-Rasmus