Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:55021
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain lerdorf.com from 209.85.210.170 cause and error)
Message-ID: <4E5DB4E8.4030509@lerdorf.com>
Date: Tue, 30 Aug 2011 21:13:28 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110812 Thunderbird/6.0
MIME-Version: 1.0
To: Stas Malyshev <smalyshev@sugarcrm.com>
CC: PHP Internals <internals@lists.php.net>, jeraimee@php.net
References: <4E5DACD6.1000002@sugarcrm.com>
In-Reply-To: <4E5DACD6.1000002@sugarcrm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] 5.4 beta & tests
From: rasmus@lerdorf.com (Rasmus Lerdorf)

On 08/30/2011 08:39 PM, Stas Malyshev wrote:
> Hi!
> 
> I've checked the unit tests on my Mac and I see 48 failures so far. I've
> put them here:
> https://wiki.php.net/todo/tests54?&#tested_2011-08-30_on_mac_os_x
> 
> Most of them are mysql, but others too.
> So, is there anybody working or willing to work to fix them all for
> beta? Should we postpone the beta for a week to wait for that or it
> doesn't make difference?

I say we postpone. We really need to get used to the fact that failing
tests matter and that they block releases.

Why is your tests/func/005a.phpt failing? That seems to pass
consistently for most people.

tests/lang/045.phpt is the one that fails for everyone because we don't
re-apply the timeout for a registered shutdown function. We should
either fix that or mark it as an XFAIL.

The two openbasedir tests were broken by these commits:

http://svn.php.net/viewvc/php/php-src/branches/PHP_5_4/tests/security/open_basedir_linkinfo.phpt?r1=311033&r2=311509

http://svn.php.net/viewvc/php/php-src/branches/PHP_5_4/tests/security/open_basedir_readlink.phpt?r1=311033&r2=311507

which you merged from trunk based on changes by jeraimee:

http://svn.php.net/viewvc/php/php-src/trunk/tests/security/open_basedir_linkinfo.phpt?r1=296679&r2=311141

so we should figure out why that was changed. I don't think this
behaviour is difference between trunk and 5.4 so I don't understand the
change.

ext/date/tests/bug33532.phpt doesn't fail for me. LOCALE differences?
What is your diff on that one?

I'm not sure how we should attack it, but I think with a little bit of
discussion on each failing test we can plow through these pretty quickly.

-Rasmus