Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:54919
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <887FE7CFF6F8DE4BB3A9535F53AFD06A495AD74C@il-ex2.zend.net>
References: <1314115682.2635.98.camel@guybrush>
	<4E545A6C.60704@akbkhome.com>
	<CAH-PCH5jyEQZvwgqxkUpqN7a-VUc+nYt=_ixFQ1si64xxMBw4A@mail.gmail.com>
	<4E54C658.6070209@akbkhome.com>
	<887FE7CFF6F8DE4BB3A9535F53AFD06A495AAA2F@il-ex2.zend.net>
	<CAEZPtU4TQ_-FnrqosWfLx8xvQvgtPi2BnhkV3o=J43056Lxoeg@mail.gmail.com>
	<887FE7CFF6F8DE4BB3A9535F53AFD06A495AAE17@il-ex2.zend.net>
	<CAEZPtU5Hy6rqbj0DMVg+HhJ2yMoSA2O4ErNpwbe0JuKc0t=jrw@mail.gmail.com>
	<887FE7CFF6F8DE4BB3A9535F53AFD06A495AB00F@il-ex2.zend.net>
	<CAEZPtU7MLoH=vQ2S12keYtPtoQT9fDb9YLQrF4qOSU=iA0M+nw@mail.gmail.com>
	<887FE7CFF6F8DE4BB3A9535F53AFD06A495AB153@il-ex2.zend.net>
	<4E54F0D6.9030005@akbkhome.com>
	<4E552E46.6070405@sugarcrm.com>
	<4E5562E1.3070005@lsces.co.uk>
	<CAH-PCH6ynedENVL4h=VRA9cEzV5YULcfg7x3O-VkmJw_eg_0tw@mail.gmail.com>
	<4E556E47.3070301@sugarcrm.com>
	<4E558B62.1040607@akbkhome.com>
	<4E55A0F3.7090002@sugarcrm.com>
	<4E55AA89.5050505@akbkhome.com>
	<CAEZPtU4BgHNhgxwLAimncVc5jdcy9uH63OBt-F0ZFsycAp0ZuQ@mail.gmail.com>
	<887FE7CFF6F8DE4BB3A9535F53AFD06A495AD74C@il-ex2.zend.net>
Date: Thu, 25 Aug 2011 10:42:58 +0200
Message-ID: <CAEZPtU5Day0wAKLXgMVSnygB-WfTm-gTdMsVjiAAr5oPZSMieg@mail.gmail.com>
To: Zeev Suraski <zeev@zend.com>
Cc: "alan@akbkhome.com" <alan@akbkhome.com>, Stas Malyshev <smalyshev@sugarcrm.com>, 
	"internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] PHP 5.3.8 Released!
From: pierre.php@gmail.com (Pierre Joye)

On Thu, Aug 25, 2011 at 10:39 AM, Zeev Suraski <zeev@zend.com> wrote:
>> -----Original Message-----
>> From: Pierre Joye [mailto:pierre.php@gmail.com]
>> Sent: Thursday, August 25, 2011 11:31 AM
>> To: alan@akbkhome.com
>> Cc: Stas Malyshev; internals@lists.php.net
>> Subject: Re: [PHP-DEV] PHP 5.3.8 Released!
>>
>> On Thu, Aug 25, 2011 at 3:51 AM, alan@akbkhome.com
>> <alan@akbkhome.com> wrote:
>>
>> > BTW. we could really do with a searchable archive of php.dev + interna=
ls...
>> > - It's pretty difficult to find out if this was ever discussed before.=
.
>>
>> Again, it was discussed already and the argument of using instanceof was=
 used
>> to deprecate is_a (along other arguments). I see no point to argue again=
 about
>> that. It was a mistake to change it again in 5.3, Zeev realized the use =
in this
>> exact case, let move on now. Revert that in 5.3 and do it only in 5.4.
>
> Just so that my position is clear on the matter:
> - I still think that is_a() is working properly the way it does now, afte=
r the change.
> - I think the code in isError() is wrong, and should be fixed.
> - Had we (the collective we) known that fixing is_a() would result in suc=
h breakage, it would have probably been wise not to fix it in 5.3.x, and wa=
it for 5.4 for this purpose.
> - Given that we've already done it - I wouldn't revert it. Fix it in PEAR=
. =A0That's the only way to create something that works across all versions=
 of 5.3.x.

I won't battle endlessly to get that fixed back again (you will always
find smtg else to keep that thing in anyway ;-) but it does confirm
what I said earlier about changing behaviors in patch releases. This
is something we must deal with much more carefully. And using x.y.0
tests as base is a good start, also the BC breakages are now covered
by the RFC, let stick to that for 5.4.x.


Cheers,
--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org