Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:54918 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 79474 invoked from network); 25 Aug 2011 08:39:57 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 25 Aug 2011 08:39:57 -0000 Authentication-Results: pb1.pair.com header.from=zeev@zend.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=zeev@zend.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.199.177.89 as permitted sender) X-PHP-List-Original-Sender: zeev@zend.com X-Host-Fingerprint: 212.199.177.89 il-mr1.zend.com Received: from [212.199.177.89] ([212.199.177.89:57579] helo=il-mr1.zend.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8F/11-06524-B5A065E4 for ; Thu, 25 Aug 2011 04:39:56 -0400 Received: from il-gw1.zend.com (unknown [10.1.1.22]) by il-mr1.zend.com (Postfix) with ESMTP id D8CD060714; Thu, 25 Aug 2011 11:38:40 +0300 (IDT) Received: from IL-EX2.zend.net ([fe80::6d27:be2c:57f3:272a]) by il-ex2.zend.net ([::1]) with mapi id 14.01.0255.000; Thu, 25 Aug 2011 11:39:06 +0300 To: Pierre Joye , "alan@akbkhome.com" CC: Stas Malyshev , "internals@lists.php.net" Thread-Topic: [PHP-DEV] PHP 5.3.8 Released! Thread-Index: AQHMYa7ZctuT+UGc90uFwsF80NSTy5UrDJAAgABg/QCAAB+qAIAAP6dQ///d6ICAADNWAP//0rEAgAA1KYD//9KDgAAGT0cA///U7ACAAEk9AIAAPraAgAAIj4CAAAUHgIAAIrMAgAAZtYCAAAtugIAAb5gA///MHmA= Date: Thu, 25 Aug 2011 08:39:05 +0000 Message-ID: <887FE7CFF6F8DE4BB3A9535F53AFD06A495AD74C@il-ex2.zend.net> References: <1314115682.2635.98.camel@guybrush> <4E545A6C.60704@akbkhome.com> <4E54C658.6070209@akbkhome.com> <887FE7CFF6F8DE4BB3A9535F53AFD06A495AAA2F@il-ex2.zend.net> <887FE7CFF6F8DE4BB3A9535F53AFD06A495AAE17@il-ex2.zend.net> <887FE7CFF6F8DE4BB3A9535F53AFD06A495AB00F@il-ex2.zend.net> <887FE7CFF6F8DE4BB3A9535F53AFD06A495AB153@il-ex2.zend.net> <4E54F0D6.9030005@akbkhome.com> <4E552E46.6070405@sugarcrm.com> <4E5562E1.3070005@lsces.co.uk> <4E556E47.3070301@sugarcrm.com> <4E558B62.1040607@akbkhome.com> <4E55A0F3.7090002@sugarcrm.com> <4E55AA89.5050505@akbkhome.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [212.199.177.84] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: RE: [PHP-DEV] PHP 5.3.8 Released! From: zeev@zend.com (Zeev Suraski) > -----Original Message----- > From: Pierre Joye [mailto:pierre.php@gmail.com] > Sent: Thursday, August 25, 2011 11:31 AM > To: alan@akbkhome.com > Cc: Stas Malyshev; internals@lists.php.net > Subject: Re: [PHP-DEV] PHP 5.3.8 Released! >=20 > On Thu, Aug 25, 2011 at 3:51 AM, alan@akbkhome.com > wrote: >=20 > > BTW. we could really do with a searchable archive of php.dev + internal= s... > > - It's pretty difficult to find out if this was ever discussed before.. >=20 > Again, it was discussed already and the argument of using instanceof was = used > to deprecate is_a (along other arguments). I see no point to argue again = about > that. It was a mistake to change it again in 5.3, Zeev realized the use i= n this > exact case, let move on now. Revert that in 5.3 and do it only in 5.4. Just so that my position is clear on the matter: - I still think that is_a() is working properly the way it does now, after = the change. - I think the code in isError() is wrong, and should be fixed. - Had we (the collective we) known that fixing is_a() would result in such = breakage, it would have probably been wise not to fix it in 5.3.x, and wait= for 5.4 for this purpose. - Given that we've already done it - I wouldn't revert it. Fix it in PEAR. = That's the only way to create something that works across all versions of = 5.3.x. Zeev