Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:54899 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 10443 invoked from network); 24 Aug 2011 21:47:27 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Aug 2011 21:47:27 -0000 Authentication-Results: pb1.pair.com smtp.mail=tyra3l@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=tyra3l@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.170 as permitted sender) X-PHP-List-Original-Sender: tyra3l@gmail.com X-Host-Fingerprint: 209.85.161.170 mail-gx0-f170.google.com Received: from [209.85.161.170] ([209.85.161.170:38330] helo=mail-gx0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 30/D3-24735-E61755E4 for ; Wed, 24 Aug 2011 17:47:27 -0400 Received: by gxk27 with SMTP id 27so1555305gxk.29 for ; Wed, 24 Aug 2011 14:47:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=m/mKInucFwP8YJYi0x/b49Sm56wQA/96awQF7xMnDIw=; b=i2abt/jalQtPdcSGFiHSRPI2B7twMv3us+e5XF3ZcrIcrOmB8Q61kEZU4NDRbMRaYx KrtNF/pf7QNv9555nHrO8bT7YA3MdUq3RiAZE9uuVR/4RcVjCy/uvqicArDDjgCPXBHY bOJ+5q2I0ImVmkb9xwInkhwwRQRU4W+R2h+JA= MIME-Version: 1.0 Received: by 10.236.200.164 with SMTP id z24mr33656432yhn.84.1314222442806; Wed, 24 Aug 2011 14:47:22 -0700 (PDT) Received: by 10.146.83.5 with HTTP; Wed, 24 Aug 2011 14:47:22 -0700 (PDT) In-Reply-To: <4E556E47.3070301@sugarcrm.com> References: <1314115682.2635.98.camel@guybrush> <4E545A6C.60704@akbkhome.com> <4E54C658.6070209@akbkhome.com> <887FE7CFF6F8DE4BB3A9535F53AFD06A495AAA2F@il-ex2.zend.net> <887FE7CFF6F8DE4BB3A9535F53AFD06A495AAE17@il-ex2.zend.net> <887FE7CFF6F8DE4BB3A9535F53AFD06A495AB00F@il-ex2.zend.net> <887FE7CFF6F8DE4BB3A9535F53AFD06A495AB153@il-ex2.zend.net> <4E54F0D6.9030005@akbkhome.com> <4E552E46.6070405@sugarcrm.com> <4E5562E1.3070005@lsces.co.uk> <4E556E47.3070301@sugarcrm.com> Date: Wed, 24 Aug 2011 23:47:22 +0200 Message-ID: To: Stas Malyshev Cc: Lester Caine , PHP internals Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] PHP 5.3.8 Released! From: tyra3l@gmail.com (Ferenc Kovacs) On Wed, Aug 24, 2011 at 11:33 PM, Stas Malyshev wr= ote: > Hi! > > Thanks for providing the timeline. > > On 8/24/11 2:15 PM, Ferenc Kovacs wrote: >> >> 5, Helgi fixed Pear in the meanwhile >> >> http://svn.php.net/viewvc/pear/pear-core/tags/PEAR-1.9.5/PEAR.php?r1=3D3= 13081&r2=3D313083&pathrev=3D313340 > > This fix doesn't look good - it doesn't do what is was meant to do. /o\, I didn't noticed it until you mentioned... > >> 7, Helgi reverts the Pear fix >> >> http://svn.php.net/viewvc/pear/pear-core/tags/PEAR-1.9.5/PEAR.php?r1=3D3= 13340&r2=3D313339&pathrev=3D313340 > > And this should be using instanceof instead. yep, I think the main reason that is_a was used in the first place is the fact that instanceof was added with php 5... obviously there is no point in watching out for php4 compatibility anymore. or at least it shouldn't be. --=20 Ferenc Kov=C3=A1cs @Tyr43l - http://tyrael.hu