Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:54888
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <4E553CA5.4050401@sugarcrm.com>
References: <4e553b46.843cdf0a.0d43.4d1a@mx.google.com>
	<4E553CA5.4050401@sugarcrm.com>
Date: Wed, 24 Aug 2011 20:05:44 +0200
Message-ID: <CAEZPtU5SQHjjHxrUvwwQDbA8JVn3kqj8fCnC-FY7V3qrFeM45Q@mail.gmail.com>
To: Stas Malyshev <smalyshev@sugarcrm.com>
Cc: "alan@akbkhome.com" <alan@akbkhome.com>, "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Subject: Re: [PHP-DEV] PHP 5.3.8 Released!
From: pierre.php@gmail.com (Pierre Joye)

On Wed, Aug 24, 2011 at 8:02 PM, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> Hi!
>
> On 8/24/11 10:56 AM, pierre.php@gmail.com wrote:
>>
>> What are you talking about? The change is exactly about that, change the
>> behavior when a string is passed.
>
> Code relying on passing string to is_a is buggy, since it is clearly
> documented as accepting object. That's what I am talking about. If your code
> relies on that, it has a bug, fix it.

As it was working perfectly fine until now, it was perfectly fine to
use is_a only to valid possible instances of a given class, passing a
non object returned false, which was totally correct (per se).

Now call that a bug, fine, but it is a breakage in a patch release.

>> We are back to the discussion about undeprecating is_a, from scratch...
>
> No we're not. It is not deprecated, nobody proposes to deprecate it - how
> we're back?

About why it should not suddenly changes this working perfectly fine
before. And about not calling autoload.

Arguments have been given, by many and in all possible ways. I do not
see a consensus coming out (while Zeev just realized what we are
talking about when we say 'breakage'). I propose to go for a vote to
see what we should do with this fix in the 5.3 branch.

-- 
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org