Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:54878
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 212.199.177.89 as permitted sender)
To: "alan@akbkhome.com" <alan@akbkhome.com>
CC: "internals@lists.php.net" <internals@lists.php.net>
Thread-Topic: [PHP-DEV] PHP 5.3.8 Released!
Thread-Index: AQHMYa7ZctuT+UGc90uFwsF80NSTy5UrDJAAgABg/QCAAB+qAIAAP6dQ///d6ICAADNWAP//0rEAgAA1KYD//9KDgAAGT0cA///U7AD//8ztgA==
Date: Wed, 24 Aug 2011 12:50:56 +0000
Message-ID: <887FE7CFF6F8DE4BB3A9535F53AFD06A495AB2E5@il-ex2.zend.net>
References: <1314115682.2635.98.camel@guybrush>
	<4E545A6C.60704@akbkhome.com>
	<CAH-PCH5jyEQZvwgqxkUpqN7a-VUc+nYt=_ixFQ1si64xxMBw4A@mail.gmail.com>
	<4E54C658.6070209@akbkhome.com>
	<887FE7CFF6F8DE4BB3A9535F53AFD06A495AAA2F@il-ex2.zend.net>
	<CAEZPtU4TQ_-FnrqosWfLx8xvQvgtPi2BnhkV3o=J43056Lxoeg@mail.gmail.com>
	<887FE7CFF6F8DE4BB3A9535F53AFD06A495AAE17@il-ex2.zend.net>
	<CAEZPtU5Hy6rqbj0DMVg+HhJ2yMoSA2O4ErNpwbe0JuKc0t=jrw@mail.gmail.com>
	<887FE7CFF6F8DE4BB3A9535F53AFD06A495AB00F@il-ex2.zend.net>
 <CAEZPtU7MLoH=vQ2S12keYtPtoQT9fDb9YLQrF4qOSU=iA0M+nw@mail.gmail.com>
 <887FE7CFF6F8DE4BB3A9535F53AFD06A495AB153@il-ex2.zend.net>
 <4E54F0D6.9030005@akbkhome.com>
In-Reply-To: <4E54F0D6.9030005@akbkhome.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: RE: [PHP-DEV] PHP 5.3.8 Released!
From: zeev@zend.com (Zeev Suraski)

Well, I have to admit this is mighty convincing :)  Wasn't aware of this us=
e-case.  Falls under the category of mass breakage I guess.

Zeev


> -----Original Message-----
> From: alan@akbkhome.com [mailto:alan@akbkhome.com]
> Sent: Wednesday, August 24, 2011 3:39 PM
> To: Zeev Suraski; internals@lists.php.net
> Subject: Re: [PHP-DEV] PHP 5.3.8 Released!
>=20
> " If it's a clear bug, which IMHO this is_a() issue was - then unless we'=
re
> looking at code breakage at massive scale, it should be fixed. "
>=20
> mmh.. how much breakage did you want.
>=20
> PEAR::isError is basically is_a($input, 'PEAR_Error'); it's been like tha=
t for > 8
> years....
>=20
> google search for PEAR::isError shows 16,600 matches..
>=20
> http://www.google.com/codesearch#search/&q=3DPEAR::isError%20lang:php&
> type=3Dcs
> <http://www.google.com/codesearch#search/&q=3DPEAR::isError%20lang:php
> &type=3Dcs>
>=20
> for is_a you get 149K. and this is only public code...
>=20
> It's big... Luckily quite a few people are on holiday this month and will=
 not
> upgrade too soon.
>=20
> Regards
> Alan
>=20
>=20
>=20
> On Wednesday, August 24, 2011 08:22 PM, Zeev Suraski wrote:
> >
> > It has nothing to do with security (criticality is subjective so I'm le=
aving it
> aside).  The 3 bugs I mentioned (2 from 5.3.7 and one imaginary) have not=
hing
> to do with security, and yet we fixed them (or would have fixed them), de=
spite
> the potential for people out there relying on the old behavior. It boils =
down to
> evaluating the severity of the bug and the likelihood that it'll break co=
de.  If it's
> a clear bug, which IMHO this is_a() issue was - then unless we're looking=
 at
> code breakage at massive scale, it should be fixed.
> >
> > Again, I'm almost religious about retaining compatibility (even across =
major
> versions), but if we had a piece of code that was returning clearly the w=
rong
> value, we can't ignore it because some (my guess very few but who knows)
> relied on this behavior.
> >
> > Zeev
> >