Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:54877 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 21233 invoked from network); 24 Aug 2011 12:42:43 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Aug 2011 12:42:43 -0000 Authentication-Results: pb1.pair.com smtp.mail=pierre.php@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=pierre.php@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.42 as permitted sender) X-PHP-List-Original-Sender: pierre.php@gmail.com X-Host-Fingerprint: 209.85.218.42 mail-yi0-f42.google.com Received: from [209.85.218.42] ([209.85.218.42:63974] helo=mail-yi0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 1D/5E-48631-1C1F45E4 for ; Wed, 24 Aug 2011 08:42:42 -0400 Received: by yie16 with SMTP id 16so1070267yie.29 for ; Wed, 24 Aug 2011 05:42:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=HX7bizDGKADmJncSUApB61u5/i9DOZ/hwt5m9juZEFE=; b=CKmMgoFXY0FDtIH1lkW29wbJkoidRaVcDQzctB3OSxr6k5ENu00hQW7jbZIvdlEhiw aHjwHTcuUS1VIPaslm+jRSG34DtD3uE69qgIpJQMB1lLNa21g1/tYirCanbHzfs+AnI0 HtwzBGbN4gnhgmP+7MMKqWvMXe9xFNu82INvI= MIME-Version: 1.0 Received: by 10.146.8.34 with SMTP id 34mr5133462yah.0.1314189759376; Wed, 24 Aug 2011 05:42:39 -0700 (PDT) Received: by 10.147.168.5 with HTTP; Wed, 24 Aug 2011 05:42:39 -0700 (PDT) In-Reply-To: <4E54F0D6.9030005@akbkhome.com> References: <1314115682.2635.98.camel@guybrush> <4E545A6C.60704@akbkhome.com> <4E54C658.6070209@akbkhome.com> <887FE7CFF6F8DE4BB3A9535F53AFD06A495AAA2F@il-ex2.zend.net> <887FE7CFF6F8DE4BB3A9535F53AFD06A495AAE17@il-ex2.zend.net> <887FE7CFF6F8DE4BB3A9535F53AFD06A495AB00F@il-ex2.zend.net> <887FE7CFF6F8DE4BB3A9535F53AFD06A495AB153@il-ex2.zend.net> <4E54F0D6.9030005@akbkhome.com> Date: Wed, 24 Aug 2011 14:42:39 +0200 Message-ID: To: "alan@akbkhome.com" Cc: Zeev Suraski , "internals@lists.php.net" Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [PHP-DEV] PHP 5.3.8 Released! From: pierre.php@gmail.com (Pierre Joye) Hi Alan, the breakage is about is_a with a string as 1st argument, not is_a as a whole. So yes, it breaks is_a alone is used as validation. On Wed, Aug 24, 2011 at 2:38 PM, alan@akbkhome.com wrote: > " If it's a clear bug, which IMHO this is_a() issue was - then unless we're > looking at code breakage at massive scale, it should be fixed. " > > mmh.. how much breakage did you want. > > PEAR::isError is basically is_a($input, 'PEAR_Error'); it's been like that > for > 8 years.... > > google search for PEAR::isError shows 16,600 matches.. > > http://www.google.com/codesearch#search/&q=PEAR::isError%20lang:php&type=cs > > > for is_a you get 149K. and this is only public code... > > It's big... Luckily quite a few people are on holiday this month and will > not upgrade too soon. -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org