Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:54876 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 19840 invoked from network); 24 Aug 2011 12:38:57 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Aug 2011 12:38:57 -0000 Authentication-Results: pb1.pair.com header.from=alan@akbkhome.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=alan@akbkhome.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain akbkhome.com designates 202.81.246.113 as permitted sender) X-PHP-List-Original-Sender: alan@akbkhome.com X-Host-Fingerprint: 202.81.246.113 246-113.netfront.net Received: from [202.81.246.113] ([202.81.246.113:43683] helo=246-113.netfront.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 2E/0E-48631-ED0F45E4 for ; Wed, 24 Aug 2011 08:38:55 -0400 Received: from akdesk ([192.168.0.40]) by akbkhome.com with esmtpa (Mailfort v1.2) (envelope-from ) id 1QwCjH-0007zx-8Y; Wed, 24 Aug 2011 20:38:47 +0800 Message-ID: <4E54F0D6.9030005@akbkhome.com> Date: Wed, 24 Aug 2011 20:38:46 +0800 User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.18) Gecko/20110617 Thunderbird/3.1.11 MIME-Version: 1.0 To: Zeev Suraski , "internals@lists.php.net" References: <1314115682.2635.98.camel@guybrush> <4E545A6C.60704@akbkhome.com> <4E54C658.6070209@akbkhome.com> <887FE7CFF6F8DE4BB3A9535F53AFD06A495AAA2F@il-ex2.zend.net> <887FE7CFF6F8DE4BB3A9535F53AFD06A495AAE17@il-ex2.zend.net> <887FE7CFF6F8DE4BB3A9535F53AFD06A495AB00F@il-ex2.zend.net> <887FE7CFF6F8DE4BB3A9535F53AFD06A495AB153@il-ex2.zend.net> In-Reply-To: <887FE7CFF6F8DE4BB3A9535F53AFD06A495AB153@il-ex2.zend.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-mailfort-sig: a695656423f1ed7d918d9102c32ee833 Subject: Re: [PHP-DEV] PHP 5.3.8 Released! From: alan@akbkhome.com ("alan@akbkhome.com") " If it's a clear bug, which IMHO this is_a() issue was - then unless we're looking at code breakage at massive scale, it should be fixed. " mmh.. how much breakage did you want. PEAR::isError is basically is_a($input, 'PEAR_Error'); it's been like that for > 8 years.... google search for PEAR::isError shows 16,600 matches.. http://www.google.com/codesearch#search/&q=PEAR::isError%20lang:php&type=cs for is_a you get 149K. and this is only public code... It's big... Luckily quite a few people are on holiday this month and will not upgrade too soon. Regards Alan On Wednesday, August 24, 2011 08:22 PM, Zeev Suraski wrote: > > It has nothing to do with security (criticality is subjective so I'm leaving it aside). The 3 bugs I mentioned (2 from 5.3.7 and one imaginary) have nothing to do with security, and yet we fixed them (or would have fixed them), despite the potential for people out there relying on the old behavior. It boils down to evaluating the severity of the bug and the likelihood that it'll break code. If it's a clear bug, which IMHO this is_a() issue was - then unless we're looking at code breakage at massive scale, it should be fixed. > > Again, I'm almost religious about retaining compatibility (even across major versions), but if we had a piece of code that was returning clearly the wrong value, we can't ignore it because some (my guess very few but who knows) relied on this behavior. > > Zeev >