Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:54856 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 79662 invoked from network); 24 Aug 2011 10:24:05 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 24 Aug 2011 10:24:05 -0000 Authentication-Results: pb1.pair.com smtp.mail=tyra3l@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=tyra3l@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.42 as permitted sender) X-PHP-List-Original-Sender: tyra3l@gmail.com X-Host-Fingerprint: 209.85.213.42 mail-yw0-f42.google.com Received: from [209.85.213.42] ([209.85.213.42:57012] helo=mail-yw0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id EF/D5-48631-441D45E4 for ; Wed, 24 Aug 2011 06:24:04 -0400 Received: by ywb3 with SMTP id 3so966601ywb.29 for ; Wed, 24 Aug 2011 03:24:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=KjY03TV1ZNtv7aem6ShkkD4aWZ73MYT53oq6vaD2/1c=; b=J84FYGdhe0sonZN1vYtELVWtCq9YtHmsf1igP8RaM+XbHWRqoi+gcLov7u0i+YpnEM TaUQdjMOgcRcpOLu/zopDicX0NW/uOmJFtgzv6XRg1UB+fPWxl90TNjvtki7lorajflW V3wX5KGMqiE19sDzCIl5LOf/WZv2K3/2xRprY= MIME-Version: 1.0 Received: by 10.236.136.167 with SMTP id w27mr29316375yhi.102.1314181440088; Wed, 24 Aug 2011 03:24:00 -0700 (PDT) Received: by 10.146.83.5 with HTTP; Wed, 24 Aug 2011 03:24:00 -0700 (PDT) In-Reply-To: References: <1314115682.2635.98.camel@guybrush> <4E545A6C.60704@akbkhome.com> Date: Wed, 24 Aug 2011 12:24:00 +0200 Message-ID: To: Pierre Joye Cc: Derick Rethans , "alan@akbkhome.com" , internals@lists.php.net Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] PHP 5.3.8 Released! From: tyra3l@gmail.com (Ferenc Kovacs) On Wed, Aug 24, 2011 at 12:00 PM, Pierre Joye wrote: > agreed. > about this specific change: the real problem is that nobody spotted this change until we rolled out the stable release, after that we can only chose from bad options. we could have spotted this via two ways: - those who participated in fixing https://bugs.php.net/bug.php?id=3D53727 could have spotted this - our tests should have start failing after the change AFAIK non of that happened, and fixing the first is hard, so I would propose fixing the second (I know, it is already agreed and worked toward) another problem is that the current(and before the change also) proto was not forced by the function, so if is_a() would raise warnings when non-object is passed to the first argument, this BC break would have much less impact. so I got the idea that it would be usefull, if somebody could write a script which fetches the proto for the functions/methods and does some fuzzing which checks if the protos are enforced. after that, we would have a list, and probably we could fix those (changing the proto and the docs to the real behaviour, or vica versa), and we could see whether the fix would impy BC and for those cases we could just keep it as is for the stable branch and create tests which would guarantee that changing the current behavior in the stable branch wouldn't go unnoticed. --=20 Ferenc Kov=C3=A1cs @Tyr43l - http://tyrael.hu