Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:54812
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CABBJUpeHX4FO5no+W811cUWB-_faAgzjTXRSZv8HgOG_y05Wgw@mail.gmail.com>
References: <CABBJUpdt-gL49tZg3LfPO+rUc+_roJ=ApKPKebFJESim9BrH1Q@mail.gmail.com>
	<CADNQb0XcUYMmHRzaVLHt2oH4WBAwD5gMXHFMOV__UYHbE=AZ8w@mail.gmail.com>
	<4E145FE2.5000001@php.net>
	<CABBJUpdCr8S3ciphLOBrnXoxLMdBqN9SppXxCAJ3EZOdKjUB5Q@mail.gmail.com>
	<CAF+90c8K-_7428c=Y=y+zY+koDkCBnt=fMTZ=2mFOLdyV0thbA@mail.gmail.com>
	<CABBJUpeHX4FO5no+W811cUWB-_faAgzjTXRSZv8HgOG_y05Wgw@mail.gmail.com>
Date: Tue, 23 Aug 2011 11:43:56 +0800
Message-ID: <CABBJUpd25G-WhZUsONRASQy2iRuXPPoBvhcCZWOheRjhXLL70Q@mail.gmail.com>
To: internals@lists.php.net
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] foreach_variable supporting T_LIST token
From: laruence@gmail.com (Xinchen Hui)

Hi:
     I found this feature was decided to do in PHP 5.3 TODO list :
http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/TODO?revision=3D2429=
49&view=3Dmarkup

    so I was wondering does this previous decision still shoudl be
think as valid?  hehe

thanks

2011/7/7 Xinchen Hui <laruence@gmail.com>:
> Hi:
>
> =C2=A0 thanks very much for this, that second patch is a wrong one, =C2=
=A0updated ..
>
> thanks
>
> 2011/7/7 Nikita Popov <nikita.ppv@googlemail.com>:
>> +1 for adding this.
>>
>> I don't know enough C to review the patches. The first one looks fine th=
ough
>> at first glance (apart from some CS *nits probably, like duplicate
>> parenthesis and usage of if {} else { if {} else {}} instead of if {} el=
seif
>> {} else {}).
>>
>> Your second patch (the one for adding the silence operator) though seems
>> strange. For example you are calling zend_do_begin_silence regardless of
>> whether '@' was used, don't you?
>>
>>
>> On Wed, Jul 6, 2011 at 3:33 PM, Xinchen Hui <laruence@gmail.com> wrote:
>>>
>>> Hi:
>>>
>>> =C2=A0first of all, I am a guy whose english is poor, sorry for making =
you
>>> confuse.
>>>
>>> =C2=A0the feature request is here: https://bugs.php.net/bug.php?id=3D10=
203
>>>
>>> =C2=A0and I think this can make php code more flexible, and more making=
 sense.
>>>
>>> =C2=A0example:
>>>
>>> =C2=A0foreach (array(
>>> =C2=A0 =C2=A0 =C2=A0 array(3, array(1, 2)),
>>> =C2=A0 =C2=A0 =C2=A0 array(7, array(3, 4)),
>>> =C2=A0 =C2=A0 =C2=A0) as list($sum, list($op1, $op2))) {
>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0printf("%d + %d =C2=A0=3D %d\n", $op1, $op2,=
 $sum);
>>> =C2=A0}
>>>
>>> =C2=A0output:
>>> =C2=A01 + 2 =C2=A0=3D 3
>>> =C2=A03 + 4 =C2=A0=3D 7
>>>
>>> =C2=A0plz read the RFC for more details.
>>>
>>> thanks
>>>
>>> 2011/7/6 Stefan Neufeind <neufeind@php.net>:
>>> > Hi,
>>> >
>>> > On 07/06/2011 03:06 PM, Hannes Magnusson wrote:
>>> >> 2011/7/6 Xinchen Hui <laruence@gmail.com>:
>>> >>>
>>> >>> =C2=A0 T_LIST is not allowed to used with foreach before.
>>> >>>
>>> >>> =C2=A0 and then there comes a freature request: =C2=A0#10203 =C2=A0=
allow
>>> >>> foreach($array as list($a,$b)
>>> >>
>>> >> Ironically enough you managed to miss the last closing ), enforcing
>>> >> the point of this not being a natural syntax.
>>> >>
>>> >> Furthermore, without reading the RFC, is this the same as
>>> >> foreach($array as $a =3D> $b) {}
>>> >
>>> > No, there $a would be the key. Intention would be, as I read the RFC,
>>> > that this could be an arbitrary list.
>>> >
>>> >> or
>>> >> foreach($array as $e) {
>>> >> list($a, $b) =3D $e;
>>> >> }
>>> >
>>> > Yes, I understood if like that. Just a short notation.
>>> >
>>> >> or.. ?
>>> >>
>>> >> that really doesn't look like something PHP should support imo.
>>> >
>>> > Don't see too many bad things about the idea ...
>>> >
>>> >
>>> > Regards,
>>> > =C2=A0Stefan
>>> >
>>> > --
>>> > PHP Internals - PHP Runtime Development Mailing List
>>> > To unsubscribe, visit: http://www.php.net/unsub.php
>>> >
>>> >
>>>
>>>
>>>
>>> --
>>> =E6=83=A0=E6=96=B0=E5=AE=B8=C2=A0 =C2=A0 =C2=A0 =C2=A0 laruence
>>> Senior PHP Engineer
>>> http://www.laruence.com
>>>
>>> --
>>> PHP Internals - PHP Runtime Development Mailing List
>>> To unsubscribe, visit: http://www.php.net/unsub.php
>>>
>>
>>
>
>
>
> --
> =E6=83=A0=E6=96=B0=E5=AE=B8=C2=A0 =C2=A0 =C2=A0 =C2=A0 laruence
> Senior PHP Engineer
> http://www.laruence.com
>



--=20
=E6=83=A0=E6=96=B0=E5=AE=B8=C2=A0 =C2=A0 =C2=A0 =C2=A0 laruence
Senior PHP Engineer
http://www.laruence.com