Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:54799
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.212.42 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <20110822135210.GA14951@openwall.com>
References: <20110719234406.GB28946@openwall.com>
	<CAEZPtU7Rjn5VQm6=Lm0HxNQCjfE6k0j+Lijx6TBcpuE9ZgfRCw@mail.gmail.com>
	<CAH-PCH74xN1HUjmKWWdsYe=8V=-wm0xCDgmT1K8oEX0y+Hiubw@mail.gmail.com>
	<20110822135210.GA14951@openwall.com>
Date: Mon, 22 Aug 2011 16:01:46 +0200
Message-ID: <CAEZPtU6nzV7s455sVyMK7gbsZJOZ0K8siK2tgKHtyzaCYALehw@mail.gmail.com>
To: Solar Designer <solar@openwall.com>
Cc: Ferenc Kovacs <tyra3l@gmail.com>, PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] CRYPT_SHA256 fails tests in trunk
From: pierre.php@gmail.com (Pierre Joye)

On Mon, Aug 22, 2011 at 3:52 PM, Solar Designer <solar@openwall.com> wrote:
> On Mon, Aug 22, 2011 at 03:19:53PM +0200, Ferenc Kovacs wrote:
>> we expected this imo.
>> http://www.mail-archive.com/internals@lists.php.net/msg51683.html
>> http://www.mail-archive.com/internals@lists.php.net/msg51687.html
>
> Definitely.
>
>> On Mon, Aug 22, 2011 at 3:05 PM, Pierre Joye <pierre.php@gmail.com> wrot=
e:
>> > it seems that the changes break BC too, pls see
>> > https://bugs.php.net/bug.php?id=3D55477
>
> We may recommend to Christian to change $2a$ in existing hashes to $2x$ i=
f
> the goal is to preserve compatibility for all old passwords despite of
> the security risk associated with doing so. =A0The change as implemented
> in PHP 5.3.7+ favors security and correctness over backwards compatibilit=
y,
> but it also lets users (admins of PHP app installs) use the new $2x$
> prefix on existing hashes to preserve backwards compatibility for those
> and incur the associated security risk until all such passwords are
> changed (using $2a$ or $2y$ for newly changed passwords).
>
> No change to the PHP code is needed.

Can you add this comment to the bug please? So every user reading it
will be informed. That's also something we have to document better.

> BTW, this is not the right thread to discuss this on (the "bug" has
> nothing to do with CRYPT_SHA256).


Oops, reply to the wrong one, sorry :)


--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org