Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:54796 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 59929 invoked from network); 22 Aug 2011 13:19:58 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 22 Aug 2011 13:19:58 -0000 Authentication-Results: pb1.pair.com smtp.mail=tyra3l@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=tyra3l@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.170 as permitted sender) X-PHP-List-Original-Sender: tyra3l@gmail.com X-Host-Fingerprint: 209.85.160.170 mail-gy0-f170.google.com Received: from [209.85.160.170] ([209.85.160.170:39542] helo=mail-gy0-f170.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 63/51-49342-C77525E4 for ; Mon, 22 Aug 2011 09:19:56 -0400 Received: by gyd5 with SMTP id 5so4540643gyd.29 for ; Mon, 22 Aug 2011 06:19:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=gAMKwRN+e0P6XY3dkwXWP0tQaLK8eV7xIvXG13Lkwlc=; b=rLW3+8y9D5I1exzXn2pSCt37lwIsdzOIgHnvZKsjZEMOgAGJoeIIrGqGVSDWIS03Og ESJ23WQatwegQJEBY6ecritdaCZdTOQCi30WxpL1RM/xRM2v9UmCLXGiRxh5kzdpzlgE 1qTK6WYZLUnyOSFWXnKgPJVbFrisniqAJCSM0= MIME-Version: 1.0 Received: by 10.150.210.19 with SMTP id i19mr1835005ybg.440.1314019193492; Mon, 22 Aug 2011 06:19:53 -0700 (PDT) Received: by 10.146.83.5 with HTTP; Mon, 22 Aug 2011 06:19:53 -0700 (PDT) In-Reply-To: References: <20110719234406.GB28946@openwall.com> Date: Mon, 22 Aug 2011 15:19:53 +0200 Message-ID: To: Pierre Joye Cc: Solar Designer , PHP Internals List Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] CRYPT_SHA256 fails tests in trunk From: tyra3l@gmail.com (Ferenc Kovacs) we expected this imo. http://www.mail-archive.com/internals@lists.php.net/msg51683.html http://www.mail-archive.com/internals@lists.php.net/msg51687.html On Mon, Aug 22, 2011 at 3:05 PM, Pierre Joye wrote: > hi, > > it seems that the changes break BC too, pls see > https://bugs.php.net/bug.php?id=3D55477 > > Does that ring a bell to you? > > On Wed, Jul 20, 2011 at 1:44 AM, Solar Designer wrot= e: >> Hi, >> >> These tests fail in trunk on my x86_64 build: >> >> crypt_sha256.phpt >> crypt_variation1.phpt >> >> The differences are like this: >> >> Expected: <$5$saltstring$5B8vYYiY.CVt1RlTTf8KbXBH3hsxY/GNooZaBBGWEc5> >> Got =C2=A0 =C2=A0 =C2=A0 <$5$saltst$JTS/fkywz8NvjeCGmWDndJPi7ZrRFhQKBLNt= QZWE2C3> >> >> That is, the salts are truncated. =C2=A0There's a relevant recent change= in >> crypt.c involving the line: >> >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0salt_in_len =3D M= IN(PHP_MAX_SALT_LEN, salt_in_len); >> >> I did not investigate this for real - I am merely passing the info that >> I readily have. =C2=A0I hope this helps. >> >> Alexander >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> > > > > -- > Pierre > > @pierrejoye | http://blog.thepimp.net | http://www.libgd.org > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php > > --=20 Ferenc Kov=C3=A1cs @Tyr43l - http://tyrael.hu