Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:54794
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <20110719234406.GB28946@openwall.com>
References: <20110719234406.GB28946@openwall.com>
Date: Mon, 22 Aug 2011 15:05:44 +0200
Message-ID: <CAEZPtU7Rjn5VQm6=Lm0HxNQCjfE6k0j+Lijx6TBcpuE9ZgfRCw@mail.gmail.com>
To: Solar Designer <solar@openwall.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] CRYPT_SHA256 fails tests in trunk
From: pierre.php@gmail.com (Pierre Joye)

hi,

it seems that the changes break BC too, pls see
https://bugs.php.net/bug.php?id=3D55477

Does that ring a bell to you?

On Wed, Jul 20, 2011 at 1:44 AM, Solar Designer <solar@openwall.com> wrote:
> Hi,
>
> These tests fail in trunk on my x86_64 build:
>
> crypt_sha256.phpt
> crypt_variation1.phpt
>
> The differences are like this:
>
> Expected: <$5$saltstring$5B8vYYiY.CVt1RlTTf8KbXBH3hsxY/GNooZaBBGWEc5>
> Got =A0 =A0 =A0 <$5$saltst$JTS/fkywz8NvjeCGmWDndJPi7ZrRFhQKBLNtQZWE2C3>
>
> That is, the salts are truncated. =A0There's a relevant recent change in
> crypt.c involving the line:
>
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0salt_in_len =3D MIN(PHP_MAX_SALT_LEN, salt=
_in_len);
>
> I did not investigate this for real - I am merely passing the info that
> I readily have. =A0I hope this helps.
>
> Alexander
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
>



--=20
Pierre

@pierrejoye | http://blog.thepimp.net | http://www.libgd.org