Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:54756
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain thelounge.net designates 91.118.73.15 as permitted sender)
Message-ID: <4E5115AE.8030803@thelounge.net>
Date: Sun, 21 Aug 2011 16:26:54 +0200
Organization: the lounge interactive design
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:6.0) Gecko/20110816 Thunderbird/6.0
MIME-Version: 1.0
To: internals@lists.php.net
References: <4E510339.3000609@thelounge.net> <20110821142139.GA20933@panix.com>
In-Reply-To: <20110821142139.GA20933@panix.com>
OpenPGP: id=7F780279;
	url=http://arrakis.thelounge.net/gpg/h.reindl_thelounge.net.pub.txt
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enig41366D1245A322984B8F4019"
Subject: Re: [PHP-DEV] Failing Autotests / Bugs
From: h.reindl@thelounge.net (Reindl Harald)

--------------enig41366D1245A322984B8F4019
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable



Am 21.08.2011 16:21, schrieb Daniel Convissor:
> Hi Reindl:
>
> On Sun, Aug 21, 2011 at 03:08:09PM +0200, Reindl Harald wrote:
>> This is my try to help badly prevent broken releases like
>> 5.3.7 in the future, 54 failing tests are way too much and
>> the XFAILED should be removed until they are working
> XFAIL's should stay, in my opinion.  Their results go to the "EXPECTED
> FAILED TEST SUMMARY" so there's no confusion with stuff in the "FAILED
> TEST SUMMARY."

not really because most of them are not working ones and they should not =
appear
as long they are working - in my opinion a test have to return PASSED and=
 never
"expected to fail"

>> FAIL DateTime::diff() days -- spring type2 type2 [ext/date/tests/DateT=
ime_days-spring-type2-type2.phpt]
>> FAIL DateTime::diff() days -- spring type2 type3 [ext/date/tests/DateT=
ime_days-spring-type2-type3.phpt]
>> FAIL DateTime::diff() days -- spring type3 type2 [ext/date/tests/DateT=
ime_days-spring-type3-type2.phpt]
>> FAIL DateTime::diff() days -- spring type3 type3 [ext/date/tests/DateT=
ime_days-spring-type3-type3.phpt]
>> FAIL DateTime::sub() -- dates [ext/date/tests/DateTime_sub-dates.phpt]=

>> FAIL DateTime::sub() -- february [ext/date/tests/DateTime_sub-february=
=2Ephpt]
> That's weird.  Those are marked for XFAIL.  How were you running the
> tests and on what checkout/code base?

via rpmbuild / SPEC-File based on the fedora one

%check
%if %runselftest
cd build-apache
# Run tests, using the CLI SAPI
export NO_INTERACTION=3D1 REPORT_EXIT_STATUS=3D1 MALLOC_CHECK_=3D2 MYSQL_=
TEST_HOST=3D"localhost" MYSQL_TEST_PORT=3D"3306"
MYSQL_TEST_USER=3D"php_autotest" MYSQL_TEST_PASSWD=3D"***********" MYSQL_=
TEST_DB=3D"php_autotest"
unset TZ LANG LC_ALL
if ! make test; then
  set +x
  for f in `find .. -name \*.diff -type f -print`; do
    echo "TEST FAILURE: $f --"
    cat "$f"
    echo "-- $f result ends."
  done
  set -x
  #exit 1
fi
unset NO_INTERACTION REPORT_EXIT_STATUS MALLOC_CHECK_
%endif

> Also, it looks like you're reading from the main output list, not the
> various SUMMARY sections, which is totally inefficient because it lists=

> passes, skips, etc, too.
it is not because grep was invited


--------------enig41366D1245A322984B8F4019
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk5RFa4ACgkQhmBjz394AnnjZQCaA3o86Z4DEn4tTvwRNAVozj18
pSIAn06bWPHSiKLcqK7IlBnZT5aLHsUt
=8aeq
-----END PGP SIGNATURE-----

--------------enig41366D1245A322984B8F4019--