Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:54714 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 37591 invoked from network); 19 Aug 2011 10:44:30 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 19 Aug 2011 10:44:30 -0000 Authentication-Results: pb1.pair.com smtp.mail=hannes.magnusson@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=hannes.magnusson@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.42 as permitted sender) X-PHP-List-Original-Sender: hannes.magnusson@gmail.com X-Host-Fingerprint: 209.85.218.42 mail-yi0-f42.google.com Received: from [209.85.218.42] ([209.85.218.42:64584] helo=mail-yi0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id B9/15-11562-C8E3E4E4 for ; Fri, 19 Aug 2011 06:44:29 -0400 Received: by yie19 with SMTP id 19so2483713yie.29 for ; Fri, 19 Aug 2011 03:44:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=vQLhhuAKjQGXY6WwT1lztRFLTY85EyKklN+jHuzO2Vg=; b=sG7AtMtL9uEzC6/mTA2Oq2HYqqWEvovbIa120a7rl0LkVQYDyVLAUgXGSQTLJUWW5l QwnCSV4k/lb8jFDJ1PEDrkJ6SI/nUR6T0FkUNE3Gee3wp4RvszAu+VO7S++8exo9ue1k TKlVYW48XPy6ZKl5/qMcKHBCaQiHGOvMSXDCk= MIME-Version: 1.0 Received: by 10.236.182.34 with SMTP id n22mr6421889yhm.15.1313750666215; Fri, 19 Aug 2011 03:44:26 -0700 (PDT) Received: by 10.147.99.2 with HTTP; Fri, 19 Aug 2011 03:44:26 -0700 (PDT) In-Reply-To: <42854.62.156.253.205.1313749679.squirrel@xa8.serverdomain.org> References: <42854.62.156.253.205.1313749679.squirrel@xa8.serverdomain.org> Date: Fri, 19 Aug 2011 12:44:26 +0200 Message-ID: To: Nicolai Scheer Cc: internals@lists.php.net Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] libxml returns codes and xmlreader From: hannes.magnusson@gmail.com (Hannes Magnusson) On Fri, Aug 19, 2011 at 12:27, Nicolai Scheer wrote: > > > Hi again! > > Please excuse if this is a duplicate, my web > mailer choked on that one :/ > > ---------- > > I've > noticed, that some of the libxml return codes > get > "simplified" when used in xmlreader which can be quite > problematic. > > I opened a bug report about this behaviour: > https://bugs.php.net/bug.php?id=55459 > > The question is, wether > this is considered a bug at all or is > rather seen as a change request. > > Throughout the whole xmlreader > extension libxml's 1, 0, -1 return > codes are simply mapped to > true/false. > > The fix is trivial, but > I don't know if > changing the return code of these php functions might > break existing > code. > > I'm short of a really easy way of working > around > that problem. Of course I could rename the xmlreader extension, fix > it and could load a fixed version, but that seems awkward. Use libxml_get_errors() -Hannes