Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:54582
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.170 as permitted sender)
MIME-Version: 1.0
Sender: laruence@gmail.com
In-Reply-To: <CABBJUpeT4k=M5q8k1j5GWZ45oavFP7pS9CNL+7MT7vd-DU2j7g@mail.gmail.com>
References: <CABBJUpfez0_CKkiFSVVmYfxbF7H30Av2y9D1Nww6PE5v6dKPUw@mail.gmail.com>
	<CAM4sM9Hxn=2FJ4d51ozbKuGM4e3BMMUQ38WsEs27WAu919XSjg@mail.gmail.com>
	<CABBJUpdONFHHYpdr4RvxGRyJ13M9yONVzb-aSjx33QKziALkLA@mail.gmail.com>
	<CABBJUpeoDnuT7eXC6UzUFQni0V0zH_mivHiX=3j=UjCKJK-z7Q@mail.gmail.com>
	<CABBJUpdXUOjyWpXeRovNaFgDMQHfM5MkXXto+Rybej2u+W4xFw@mail.gmail.com>
	<alpine.DEB.2.02.1108141219470.4043@whisky>
	<CAH-PCH6_sTBGqCrCp-pgdi3DJfFX-3ZsvSr8ibbrOtKQP0qpTA@mail.gmail.com>
	<alpine.DEB.2.02.1108141359340.4043@whisky>
	<CABBJUpeT4k=M5q8k1j5GWZ45oavFP7pS9CNL+7MT7vd-DU2j7g@mail.gmail.com>
Date: Sun, 14 Aug 2011 22:02:21 +0800
Message-ID: <CABBJUpfrfqPDJp61OoUHmnzqY8ZVi=Eorz728JqzF4yg7foO_w@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: Ferenc Kovacs <tyra3l@gmail.com>, PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [VOTE]strn(case)cmp supporting a negative length as its
 third paramter
From: laruence@php.net (Laruence)

Hi:
  I think what I was done is try to describe a image, that we can make
follow codes more simple:

  if (strncmp(substr("num_suffix", 0, -5), "suffix", 5) =3D=3D 0) {
          echo "they have the same suffix";
  }

  yes,  there is must something not good in my patch,  but I think I
can tweak it as you wish.

  the only thing I want you to accept is : " should this behavior is
more make sense for some occassion?"

thanks

2011/8/14 Laruence <laruence@php.net>:
> Hi:
> =C2=A0 this just to say that stncasecmp has the same behavior of either
> negative or postive length argument.
>
> =C2=A0 why you insist to this point? =C2=A0as strncmp("aaaa", "bbb", =C2=
=A01000000)
> works with no warning, =C2=A0why negative length need trigger warnings?
>
> thanks
>
> 2011/8/14 Derick Rethans <derick@php.net>:
>> On Sun, 14 Aug 2011, Ferenc Kovacs wrote:
>>
>>> On Sun, Aug 14, 2011 at 1:24 PM, Derick Rethans <derick@php.net> wrote:
>>> > On Sat, 13 Aug 2011, Laruence wrote:
>>> >
>>> >> Dear all:
>>> >> =C2=A0 =C2=A0 I am going to close strn(case)cmp supporting negative =
length vote,
>>> >> since it has been calling for vote near two weeks, and no new feedba=
ck
>>> >> .
>>> >>
>>> >> =C2=A0 =C2=A0 the Voting result is:
>>> >> =C2=A0 =C2=A0 =C2=A0Support : =C2=A06 =C2=A0felipe pajoye pierrick g=
wynne tyrael laruence
>>> >> =C2=A0 =C2=A0 =C2=A0Decline : =C2=A03 =C2=A0iliaa rasmus salathe
>>> >>
>>> >> =C2=A0 =C2=A0 it wins 2/3 vote, =C2=A0 so I think this supposed to m=
ean that accept, =C2=A0right?
>>> >
>>> > I voted against too. Also, you started the vote with not even a week
>>> > between RFC announcement and call for voting, so I guess that makes t=
his
>>> > invalid?
>>> >
>>> >
>>> > Just looked over the RFC, and this whole example is weird:
>>> >
>>> > <?php
>>> > var_dump(strncmp("prefix_num", "num", -10));
>>> > ?>
>>> >
>>> > Why does it even find the substring as you can't do "-10" from the en=
d?
>>> > If the number is too high, it should give you a warning.
>>>
>>> imo the patch is consistent with how substr works:
>>> tyrael@thor:~$ php -d display_errors=3D1 -d error_reporting=3D-1 -r 'ec=
ho
>>> substr("prefix_num", -100);'
>>> prefix_num
>>
>> Maybe, but I would classify *that* as a bug as it makes no sense at all.
>>
>> Derick
>>
>> --
>> http://derickrethans.nl | http://xdebug.org
>> Like Xdebug? Consider a donation: http://xdebug.org/donate.php
>> twitter: @derickr and @xdebug
>
>
>
> --
> Laruence =C2=A0Xinchen Hui
> http://www.laruence.com/
>



--=20
Laruence =C2=A0Xinchen Hui
http://www.laruence.com/