Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:54576
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.02.1108141219470.4043@whisky>
References: <CABBJUpfez0_CKkiFSVVmYfxbF7H30Av2y9D1Nww6PE5v6dKPUw@mail.gmail.com>
	<CAM4sM9Hxn=2FJ4d51ozbKuGM4e3BMMUQ38WsEs27WAu919XSjg@mail.gmail.com>
	<CABBJUpdONFHHYpdr4RvxGRyJ13M9yONVzb-aSjx33QKziALkLA@mail.gmail.com>
	<CABBJUpeoDnuT7eXC6UzUFQni0V0zH_mivHiX=3j=UjCKJK-z7Q@mail.gmail.com>
	<CABBJUpdXUOjyWpXeRovNaFgDMQHfM5MkXXto+Rybej2u+W4xFw@mail.gmail.com>
	<alpine.DEB.2.02.1108141219470.4043@whisky>
Date: Sun, 14 Aug 2011 14:56:23 +0200
Message-ID: <CAH-PCH6_sTBGqCrCp-pgdi3DJfFX-3ZsvSr8ibbrOtKQP0qpTA@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: Laruence <laruence@php.net>, PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [VOTE]strn(case)cmp supporting a negative length as its
 third paramter
From: tyra3l@gmail.com (Ferenc Kovacs)

On Sun, Aug 14, 2011 at 1:24 PM, Derick Rethans <derick@php.net> wrote:
> On Sat, 13 Aug 2011, Laruence wrote:
>
>> Dear all:
>> =C2=A0 =C2=A0 I am going to close strn(case)cmp supporting negative leng=
th vote,
>> since it has been calling for vote near two weeks, and no new feedback
>> .
>>
>> =C2=A0 =C2=A0 the Voting result is:
>> =C2=A0 =C2=A0 =C2=A0Support : =C2=A06 =C2=A0felipe pajoye pierrick gwynn=
e tyrael laruence
>> =C2=A0 =C2=A0 =C2=A0Decline : =C2=A03 =C2=A0iliaa rasmus salathe
>>
>> =C2=A0 =C2=A0 it wins 2/3 vote, =C2=A0 so I think this supposed to mean =
that accept, =C2=A0right?
>
> I voted against too. Also, you started the vote with not even a week
> between RFC announcement and call for voting, so I guess that makes this
> invalid?
>
>
> Just looked over the RFC, and this whole example is weird:
>
> <?php
> var_dump(strncmp("prefix_num", "num", -10));
> ?>
>
> Why does it even find the substring as you can't do "-10" from the end?
> If the number is too high, it should give you a warning.

imo the patch is consistent with how substr works:
tyrael@thor:~$ php -d display_errors=3D1 -d error_reporting=3D-1 -r 'echo
substr("prefix_num", -100);'
prefix_num

--=20
Ferenc Kov=C3=A1cs
@Tyr43l - http://tyrael.hu