Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:54488
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain joeysmith.com designates 209.90.98.146 as permitted sender)
Date: Tue, 9 Aug 2011 01:45:19 -0600
To: internals@lists.php.net
Message-ID: <20110809074519.GD21131@joeysmith.com>
References: <4E3E0155.5050702@lerdorf.com>
 <20110809064549.GC21131@joeysmith.com>
 <4E40DF99.70601@lerdorf.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4E40DF99.70601@lerdorf.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [PHP-DEV] Coverity Scan
From: joey@joeysmith.com (Joey Smith)

On Tue, Aug 09, 2011 at 12:19:53AM -0700, Rasmus Lerdorf wrote:
> On 08/08/2011 11:45 PM, Joey Smith wrote
> > A lot of the 'STACK_USE' ones seem to be false positives; it's reporting
> > when the stack "exceeds the maximum single use of 1024 bytes" - that 1024
> > is a Coverity-configurable value which defaults to 1024.
> 
> Yup, we can simply mark those as intentional/ignore although it wouldn't
> be a bad idea to have a quick look at each one to see if we really need
> to chew up 1k of stack on each of those occasions. People using PHP in
> embedded systems would appreciate that, I bet.
> 
> -Rasmus

Quite a few of the ones I looked at were reporting it due to MAXPATHLEN,
which I imagine we probably want to leave untouched - I'll just mark those
as intentional/ignore.