Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:54475 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 81527 invoked from network); 8 Aug 2011 16:39:57 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 8 Aug 2011 16:39:57 -0000 Authentication-Results: pb1.pair.com header.from=damz@damz.org; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=damz@damz.org; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain damz.org designates 209.85.215.176 as permitted sender) X-PHP-List-Original-Sender: damz@damz.org X-Host-Fingerprint: 209.85.215.176 mail-ey0-f176.google.com Received: from [209.85.215.176] ([209.85.215.176:44892] helo=mail-ey0-f176.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 4C/35-53378-B51104E4 for ; Mon, 08 Aug 2011 12:39:56 -0400 Received: by eyz10 with SMTP id 10so3971348eyz.35 for ; Mon, 08 Aug 2011 09:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=damz.org; s=google; h=mime-version:x-originating-ip:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=SoAw2mqof8kcIFE7imFiWhC5XQNJ4AQ8H1HjHBmtlog=; b=PemYJGyLwC9FMXl2A49vzhyF6lHyjb/j6CKBMDtJFMmO3oHL04W8vjimuoFaMsOinF G3eYYuXWalGzonFa7CvCZb2f9owoDCA7pQWu7o9EZV8C/WzV+m4aYBqTitylHuNepiNL gGyYuzMJjaf3+e6uzUjiISMBDF7M5gGHeOgcI= MIME-Version: 1.0 Received: by 10.213.14.81 with SMTP id f17mr391444eba.111.1312821591068; Mon, 08 Aug 2011 09:39:51 -0700 (PDT) Received: by 10.213.35.194 with HTTP; Mon, 8 Aug 2011 09:39:51 -0700 (PDT) X-Originating-IP: [81.200.189.1] In-Reply-To: References: Date: Mon, 8 Aug 2011 18:39:51 +0200 Message-ID: To: Ilia Alshanetsky Cc: internals@lists.php.net Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [PHP-DEV] Build broken: ext/xsl/xsltprocessor.c From: damz@damz.org (Damien Tournoud) Thanks for the fix, but it is still failing in xsltprocessor.c, as far as I can tell: /tmp/buildd/php5-5.3.99+5.4.0/ext/xsl/xsltprocessor.c: In function 'xsl_ext_function_php': /tmp/buildd/php5-5.3.99+5.4.0/ext/xsl/xsltprocessor.c:242: warning: pointer targets in initialization differ in signedness /tmp/buildd/php5-5.3.99+5.4.0/ext/xsl/xsltprocessor.c:252: warning: pointer targets in assignment differ in signedness /tmp/buildd/php5-5.3.99+5.4.0/ext/xsl/xsltprocessor.c:272: warning: pointer targets in passing argument 1 of 'xmlStrdup' differ in signedness /usr/include/libxml2/libxml/xmlstring.h:41: note: expected 'const xmlChar *' but argument is of type 'char *' /tmp/buildd/php5-5.3.99+5.4.0/ext/xsl/xsltprocessor.c:275: warning: pointer targets in passing argument 3 of 'xmlNewDocNode' differ in signedness /usr/include/libxml2/libxml/tree.h:782: note: expected 'const xmlChar *' but argument is of type 'char *' /tmp/buildd/php5-5.3.99+5.4.0/ext/xsl/xsltprocessor.c:277: warning: pointer targets in passing argument 3 of 'xmlNewDocNode' differ in signedness /usr/include/libxml2/libxml/tree.h:782: note: expected 'const xmlChar *' but argument is of type 'char *' /tmp/buildd/php5-5.3.99+5.4.0/ext/xsl/xsltprocessor.c:283: warning: passing argument 4 of 'php_dom_create_object' from incompatible pointer type /tmp/buildd/php5-5.3.99+5.4.0/ext/xsl/../dom/xml_common.h:57: note: expected 'struct dom_object *' but argument is of type 'struct zval *' /tmp/buildd/php5-5.3.99+5.4.0/ext/xsl/xsltprocessor.c:283: error: too many arguments to function 'php_dom_create_object' Full log: https://drupaltesting.org/jenkins/job/php5.4-build/237/consoleFul= l Damien On Mon, Aug 8, 2011 at 6:06 PM, Ilia Alshanetsky wrote: > Thanks, I've just applied a fix for this. > > On Mon, Aug 8, 2011 at 10:45 AM, Damien Tournoud wrote: >> Just FYI, this commit broke the build: >> >> =A0http://svn.php.net/viewvc?view=3Drevision&revision=3D314515 >> >> One occurrence as been missed in: >> >> =A0ext/xsl/xsltprocessor.c: =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0DOM_RET_OBJ(rv, >> (xmlNodePtr) newdocp, &ret, NULL); >> >> Reference: https://drupaltesting.org/jenkins/job/php5.4-build/235/ >> >> Damien >> >> -- >> PHP Internals - PHP Runtime Development Mailing List >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> >