Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:54447
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: unknown (pb1.pair.com: domain php.net does not designate 91.184.32.3 as permitted sender)
Message-ID: <4E3F2CA5.8080609@php.net>
Date: Mon, 08 Aug 2011 02:24:05 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110707 Thunderbird/5.0
MIME-Version: 1.0
To: internals@lists.php.net
References: <slrnj3tulc.6vi.dsp@experimentalworks.net> <4E3F0279.3070701@sugarcrm.com> <slrnj3u12r.6vi.dsp@experimentalworks.net> <ek8vr4hphq.fsf@news.eternal-september.org> <4E3F215F.4020101@php.net> <CAH-PCH5TDmJOSLzfrxdhkieFKPGOY3bvi2Wx6JQFv10wtugR7A@mail.gmail.com>
In-Reply-To: <CAH-PCH5TDmJOSLzfrxdhkieFKPGOY3bvi2Wx6JQFv10wtugR7A@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Choosing a distributed version control system
 for PHP (or not). Call for Participation.
From: neufeind@php.net (Stefan Neufeind)

On 08/08/2011 01:44 AM, Ferenc Kovacs wrote:
> On Mon, Aug 8, 2011 at 1:35 AM, Stefan Neufeind <neufeind@php.net> wrote:
>> On 08/07/2011 11:37 PM, Richard Riley wrote:
>>> David Soria Parra <dsp@php.net> writes:
>>>
>>>> On 2011-08-07, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
>>
>> [...]
>>
>>> Its really simple.
>>>
>>> Use git.
>>>
>>> It works, is fast and is rapidly becoming the industry standard. Do not
>>> sue something for "moral grounds" like the awful bzr used for emacs.
>>>
>>> Its designed as a fast, efficient DVCS.
>>
>> Hi,
>>
>> The TYPO3-folks migrated to git some while ago. And lately their
>> review-system "review.typo3.org" (readonly now also without a login)
>> went live. The review-system itself is actually another git in front
>> where changes for review can be pushed, can be reviewed, changed and be
>> mangled around, can be finally be abandoned or merged. At merge it's
>> pushed into the main repo. That was a huge win in terms of formal
>> reviews, transparency, speed and ease of reviews etc. And it even helped
>> bug-tracking since now there are no few lines of code hidden in the
>> bugtracker as some kind of "patch" or "quickfix" but that is actually a
>> git-change that you can checkout from review.typo3.org using your git
>> (the system tells you which commandline to use for that). Imho it's
>> dead-simple.
>>
>> I believe it would help PHP a lot to have this kind of transparency and
>> increase both the quality as well as the speed/ease of reviews.
> 
> btw. for code-review and change control there are also existing open
> source tools like gerrit for git.
> http://code.google.com/p/gerrit/

They use gerrit. It's just configured with a few nice hooks like to
automatically update a ticket-status when a new patch is sent to the
review-system or when it is merged (issue referenced by "Resolves:
#xxxxx" in the comment is closed). Also a build-bot is triggered which
sends its results for each patchset into the review and things like that.


Regards,
 Stefan