Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:54367
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAEZPtU6Z9FbV-cqo4=PUbRyLTKELT8hiPe6L0K-bTmAShhZtOA@mail.gmail.com>
References: <CAF=va1VoO38yrGXpfXk+L+YZ-BiLewBe4QPkvpp7QM7MvEwn+A@mail.gmail.com>
 <CAEZPtU7mHui+1Wcf_1b4Dn9Xrm6JMMTYMb+R-S7ALSOAGrEhsA@mail.gmail.com>
 <CAF=va1U5Xm7kLhRrAsZa3VBSROTSAD_iSYnrLpzg6SkjnCFPJQ@mail.gmail.com> <CAEZPtU6Z9FbV-cqo4=PUbRyLTKELT8hiPe6L0K-bTmAShhZtOA@mail.gmail.com>
Date: Thu, 4 Aug 2011 17:23:06 +0100
Message-ID: <CAF=va1XQEwd_MgE9US6JD+dwpXzsHHFNN9ZtHwY+sqzecWo=NQ@mail.gmail.com>
To: Pierre Joye <pierre.php@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=20cf307812dc67645e04a9b07147
Subject: Re: [PHP-DEV] [PATCH] fix imap_mail actually use the rpath option
From: ava3ar@gmail.com (Keloran)

--20cf307812dc67645e04a9b07147
Content-Type: text/plain; charset=ISO-8859-1

cool, thanks

that patch is for 5.4 (since the line nums changed from 5.3-5.4,

On Thu, Aug 4, 2011 at 5:19 PM, Pierre Joye <pierre.php@gmail.com> wrote:

> I have now attached the patch to the issue:
> https://bugs.php.net/bug.php?id=30688
>
> On Thu, Aug 4, 2011 at 6:07 PM, Keloran <ava3ar@gmail.com> wrote:
> > patch attached
> >
> > On Thu, Aug 4, 2011 at 4:39 PM, Pierre Joye <pierre.php@gmail.com>
> wrote:
> >>
> >> hi,
> >>
> >> Can you attach this patch to the bug please?
> >>
> >> Thanks for your work!
> >>
> >> On Thu, Aug 4, 2011 at 5:30 PM, Keloran <ava3ar@gmail.com> wrote:
> >> > Index: ext/imap/php_imap.c
> >> > ===================================================================
> >> > --- ext/imap/php_imap.c (revision 314217)
> >> > +++ ext/imap/php_imap.c (working copy)
> >> > @@ -4016,7 +4016,27 @@
> >> >        if (!INI_STR("sendmail_path")) {
> >> >                return 0;
> >> >        }
> >> > -       sendmail = popen(INI_STR("sendmail_path"), "w");
> >> > +
> >> > +       /** Used to make return-path work **/
> >> > +        char *sendmail_path = INI_STR("sendmail_path");
> >> > +        char *appended_sendmail_path = NULL;
> >> > +
> >> > +        /** Return Path or not **/
> >> > +        if (rpath && rpath[0]) {
> >> > +            appended_sendmail_path = emalloc(
> >> > +                strlen(sendmail_path) + 3 + strlen(rpath) + 1);
> >> > +            strcpy(appended_sendmail_path, sendmail_path);
> >> > +            strcat(appended_sendmail_path, " -f");
> >> > +            strcat(appended_sendmail_path, rpath);
> >> > +            sendmail_path = appended_sendmail_path;
> >> > +        }
> >> > +
> >> > +        /** open the sendmail pointer **/
> >> > +        sendmail = popen(sendmail_path, "w"); /* New Code */
> >> > +
> >> > +       if (appended_sendmail_path)
> >> > +            efree(appended_sendmail_path);
> >> > +
> >> >        if (sendmail) {
> >> >                if (rpath && rpath[0]) fprintf(sendmail, "From: %s\n",
> >> > rpath);
> >> >                fprintf(sendmail, "To: %s\n", to);
> >> >
> >> > ================
> >> >
> >> > hopefully that will work to fix the rpath option, and finally close
> this
> >> > bug http://bugs.php.net/bug.php?id=30688
> >> >
> >>
> >>
> >>
> >> --
> >> Pierre
> >>
> >> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org
> >
> >
>
>
>
> --
> Pierre
>
> @pierrejoye | http://blog.thepimp.net | http://www.libgd.org
>

--20cf307812dc67645e04a9b07147--